From patchwork Tue Jan 9 23:04:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 857825 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="rBi04cxJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zGSSB4PqDz9s82 for ; Wed, 10 Jan 2018 10:06:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758774AbeAIXGC (ORCPT ); Tue, 9 Jan 2018 18:06:02 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:44662 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758684AbeAIXFe (ORCPT ); Tue, 9 Jan 2018 18:05:34 -0500 Received: by mail-qt0-f194.google.com with SMTP id m59so19929592qte.11; Tue, 09 Jan 2018 15:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l6D87hgRspijf88GOOe72lRm1zJsTp3X/BIZYLK9pEs=; b=rBi04cxJJ3gaxA+836PPTWZ0UcyJeBk6k5RRM1hW3lijVQu79LeXuA47ENgVPeWx1L dx8kF1P1riYTSC+I/6iAlD5dFKeDWoaAUZktWZMuNcWQT5ykmWEOySXSKNg8OSJHFI/R d8hw0WmR8w1dODKq8eGAZmbsFod8Z6TJEjXlZdtm+Zf7G3RkzSX/OOx8CQD6hsjYjpRD 5gjPqQJ1cOIs9svNECxmQ9xWZtNySMsQU+w9P5cV+7bB1L2LOP7g2jNVYMU/WU1R4I3K SN+jSoiTYGmsKo7F9CHQuL9mKFKpQZLhP3M14Wj+NGVJwc8ezx8sCnOOcwjqhKYyGucq CWEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=l6D87hgRspijf88GOOe72lRm1zJsTp3X/BIZYLK9pEs=; b=jMMJEJf/y2Xq45nGy0A23Dh4JGM+MF+abhgBwQPnpLvD86QDQsNu+vqrPDxHkUyAjF rihX87qJQbw1L82tS5F6Q0QGHH6gYQDIIQbGUq7hujS8DG2c/RuL1qUiwr8fveJAQWNn UDJ5wzAEbixQyx4r4qCFK6vZbgBbXqNDnIjwwkt/azmbS4nVov67yDGBkzD9k4MypQT+ DqlZHnz/LL3ytKO3lIPbP/ouETx/aGUZLbdKYuLotIF/udNtyMRPweExtJzo+sBPRR1O AksOpyWG6uAjkRajlhTmqUsshMpUOmbwB27ZDob3O/fkTH67qxdHS3ckV4sW3Wcm6OvZ vdmw== X-Gm-Message-State: AKwxytfBzTsy5+Akv/adkEMhBTNPF4pph8Drj2Dit9mfJ6C73j6yUSuu aM1vrPB6nJnQ2cBAknSLfiQ= X-Google-Smtp-Source: ACJfBov9e3hkKNEHDgyTX+qlTes8J1198lj68Z3VA0qjjc0fS5Yj9JZPkaHRgtvno3SFRI0zEedxTw== X-Received: by 10.200.15.24 with SMTP id e24mr7607770qtk.133.1515539133177; Tue, 09 Jan 2018 15:05:33 -0800 (PST) Received: from stbirv-lnx-3.igp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id p187sm2987468qkf.41.2018.01.09.15.05.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 Jan 2018 15:05:32 -0800 (PST) From: Florian Fainelli To: bcm-kernel-feedback-list@broadcom.com Cc: Florian Fainelli , Tejun Heo , Kishon Vijay Abraham I , Heiko Stuebner , Srinath Mannam , Krzysztof Kozlowski , Vivek Gautam , Dan Carpenter , linux-ide@vger.kernel.org (open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] phy: brcm-sata: Implementation calibrate callback Date: Tue, 9 Jan 2018 15:04:56 -0800 Message-Id: <1515539097-26742-3-git-send-email-f.fainelli@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1515539097-26742-1-git-send-email-f.fainelli@gmail.com> References: <1515539097-26742-1-git-send-email-f.fainelli@gmail.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Implement the calibration callback to allow turning on the Clock-Data Recovery module clamping when necessary. Signed-off-by: Florian Fainelli --- drivers/phy/broadcom/phy-brcm-sata.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/phy/broadcom/phy-brcm-sata.c b/drivers/phy/broadcom/phy-brcm-sata.c index 3f953db70288..8000ce312d95 100644 --- a/drivers/phy/broadcom/phy-brcm-sata.c +++ b/drivers/phy/broadcom/phy-brcm-sata.c @@ -150,6 +150,9 @@ enum sata_phy_regs { TXPMD_TX_FREQ_CTRL_CONTROL2_FMIN_MASK = 0x3ff, TXPMD_TX_FREQ_CTRL_CONTROL3 = 0x84, TXPMD_TX_FREQ_CTRL_CONTROL3_FMAX_MASK = 0x3ff, + + RXPMD_REG_BANK = 0x1c0, + RXPMD_RX_FREQ_MON_CONTROL1 = 0x87, }; enum sata_phy_ctrl_regs { @@ -505,8 +508,37 @@ static int brcm_sata_phy_init(struct phy *phy) return rc; } +static void brcm_stb_sata_calibrate(struct brcm_sata_port *port) +{ + void __iomem *base = brcm_sata_pcb_base(port); + struct brcm_sata_phy *priv = port->phy_priv; + u32 tmp = BIT(8); + + brcm_sata_phy_wr(base, RXPMD_REG_BANK, RXPMD_RX_FREQ_MON_CONTROL1, + ~tmp, tmp); +} + +static int brcm_sata_phy_calibrate(struct phy *phy) +{ + struct brcm_sata_port *port = phy_get_drvdata(phy); + int rc = -EOPNOTSUPP; + + switch (port->phy_priv->version) { + case BRCM_SATA_PHY_STB_28NM: + case BRCM_SATA_PHY_STB_40NM: + brcm_stb_sata_calibrate(port); + rc = 0; + break; + default: + break; + }; + + return rc; +} + static const struct phy_ops phy_ops = { .init = brcm_sata_phy_init, + .calibrate = brcm_sata_phy_calibrate, .owner = THIS_MODULE, };