Message ID | 1339018901-28439-2-git-send-email-Julia.Lawall@lip6.fr |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
From: Julia Lawall <Julia.Lawall@lip6.fr> Date: Wed, 6 Jun 2012 23:41:35 +0200 > - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) { > + if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH) I'm really surprised someone as thorough as yourself did not compile test this. This is just more proof that it's absolutely pointless to make any changes at all to the old IDE layer. Nobody really cares, and the risk %99.999 of the time is purely to introduce regressions rather than make forward progress. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 7 Jun 2012, David Miller wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > Date: Wed, 6 Jun 2012 23:41:35 +0200 > >> - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) { >> + if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH) > > I'm really surprised someone as thorough as yourself did not > compile test this. Sorry, I changed the patch at the last minute, and it was indeed not a good idea not to have compiled again. I will send another version, in case it is useful. julia -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ide/ide-cs.c b/drivers/ide/ide-cs.c index 28e344e..a5e57bf 100644 --- a/drivers/ide/ide-cs.c +++ b/drivers/ide/ide-cs.c @@ -167,7 +167,8 @@ static int pcmcia_check_one_config(struct pcmcia_device *pdev, void *priv_data) { int *is_kme = priv_data; - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) { + if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH) + != IO_DATA_PATH_WIDTH_8) { pdev->resource[0]->flags &= ~IO_DATA_PATH_WIDTH; pdev->resource[0]->flags |= IO_DATA_PATH_WIDTH_AUTO; }