From patchwork Wed Aug 5 02:10:41 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shane Huang X-Patchwork-Id: 30762 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by bilbo.ozlabs.org (Postfix) with ESMTP id CA5C8B708B for ; Wed, 5 Aug 2009 12:11:01 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933171AbZHECK6 (ORCPT ); Tue, 4 Aug 2009 22:10:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933232AbZHECK6 (ORCPT ); Tue, 4 Aug 2009 22:10:58 -0400 Received: from tx2ehsobe005.messaging.microsoft.com ([65.55.88.15]:32662 "EHLO TX2EHSOBE009.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933171AbZHECK6 (ORCPT ); Tue, 4 Aug 2009 22:10:58 -0400 Received: from mail2-tx2-R.bigfish.com (10.9.14.241) by TX2EHSOBE009.bigfish.com (10.9.40.29) with Microsoft SMTP Server id 8.1.340.0; Wed, 5 Aug 2009 02:10:58 +0000 Received: from mail2-tx2 (localhost.localdomain [127.0.0.1]) by mail2-tx2-R.bigfish.com (Postfix) with ESMTP id 0ADBEFA09D2; Wed, 5 Aug 2009 02:10:58 +0000 (UTC) X-SpamScore: 2 X-BigFish: VPS2(zz936eMa4a4kzz1202hzz5a6ciz32i6bh203h43j61h) X-Spam-TCS-SCL: 0:0 Received: by mail2-tx2 (MessageSwitch) id 1249438256755082_31708; Wed, 5 Aug 2009 02:10:56 +0000 (UCT) Received: from svlb1extmailp02.amd.com (unknown [139.95.251.11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail2-tx2.bigfish.com (Postfix) with ESMTP id 7F24531804B; Wed, 5 Aug 2009 02:10:56 +0000 (UTC) Received: from svlb1twp01.amd.com ([139.95.250.34]) by svlb1extmailp02.amd.com (Switch-3.2.7/Switch-3.2.7) with ESMTP id n752An70015980; Tue, 4 Aug 2009 19:10:52 -0700 X-WSS-ID: 0KNVSPR-03-8MM-01 Received: from SSVLEXBH1.amd.com (ssvlexbh1.amd.com [139.95.53.182]) by svlb1twp01.amd.com (Tumbleweed MailGate 3.5.1) with ESMTP id 2E5D188493B; Tue, 4 Aug 2009 19:10:38 -0700 (PDT) Received: from SSVLEXMB1.amd.com ([139.95.53.181]) by SSVLEXBH1.amd.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 4 Aug 2009 19:10:51 -0700 Received: from storexbh1.amd.com ([10.1.1.17]) by SSVLEXMB1.amd.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 4 Aug 2009 19:10:50 -0700 Received: from sshaexmb1.amd.com ([10.237.2.11]) by storexbh1.amd.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 4 Aug 2009 22:10:50 -0400 Received: from 10.237.82.10 ([10.237.82.10]) by sshaexmb1.amd.com ([10.237.2.11]) with Microsoft Exchange Server HTTP-DAV ; Wed, 5 Aug 2009 02:10:42 +0000 Received: from zm-desktop by sshaexmb1.amd.com; 05 Aug 2009 10:10:42 +0800 Subject: [PATCH] Soften up the dmesg on SB600 PMP softreset failure recovery From: Shane Huang Reply-To: shane.huang@amd.com To: jgarzik@pobox.com CC: linux-ide@vger.kernel.org, tj@kernel.org, pgnet.dev@gmail.com, "Huang, Shane" Organization: AMD Date: Wed, 5 Aug 2009 10:10:41 +0800 Message-ID: <1249438241.3583.5.camel@zm-desktop> MIME-Version: 1.0 X-Mailer: Evolution 2.26.1 X-OriginalArrivalTime: 05 Aug 2009 02:10:50.0174 (UTC) FILETIME=[F3F2BDE0:01CA1571] Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Too strong words led to spurious bug reports: Novell bugzilla #527748, RedHat bugzilla #468800. This patch is used to soften up the dmesg on SB600 PMP softreset failure recovery, so as to remove the scariness and concern from community. Reported-by: pgnet Dev Signed-off-by: Shane Huang Cc: Tejun Heo Acked-by: Tejun Heo --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c --- a/drivers/ata/ahci.c 2009-07-29 14:38:39.000000000 +0800 +++ b/drivers/ata/ahci.c 2009-08-04 17:24:34.000000000 +0800 @@ -1769,7 +1769,8 @@ irq_sts = readl(port_mmio + PORT_IRQ_STAT); if (irq_sts & PORT_IRQ_BAD_PMP) { ata_link_printk(link, KERN_WARNING, - "failed due to HW bug, retry pmp=0\n"); + "applying SB600 PMP SRST workaround " + "and retrying\n"); rc = ahci_do_softreset(link, class, 0, deadline, ahci_check_ready); }