mbox series

[v3,0/3] Successful NCQ commands sense_valid cleanups/fixes

Message ID 20250416093127.63666-5-cassel@kernel.org
Headers show
Series Successful NCQ commands sense_valid cleanups/fixes | expand

Message

Niklas Cassel April 16, 2025, 9:31 a.m. UTC 
Hello all,

Here comes some minor cleanups/fixes related to the sense_valid field in
the Successful NCQ commands log.


Kind regards,
Niklas


Changes since v2:
-Picked up tags.
-Changed "1ULL << tag" to "1 << tag" in patch 2/3 (Damien).
-Improved subject in patch 3/3.


Niklas Cassel (3):
  ata: libata-sata: Save all fields from sense data descriptor
  ata: libata-sata: Simplify sense_valid fetching
  ata: libata-sata: Use BIT() macro to convert tag to bit field

 drivers/ata/libata-sata.c | 25 ++++++++++++++++++++-----
 1 file changed, 20 insertions(+), 5 deletions(-)

Comments

Damien Le Moal April 16, 2025, 9:50 a.m. UTC | #1 
On 4/16/25 6:31 PM, Niklas Cassel wrote:
> Hello all,
> 
> Here comes some minor cleanups/fixes related to the sense_valid field in
> the Successful NCQ commands log.
> 
> 
> Kind regards,
> Niklas
> 
> 
> Changes since v2:
> -Picked up tags.
> -Changed "1ULL << tag" to "1 << tag" in patch 2/3 (Damien).
> -Improved subject in patch 3/3.
> 
> 
> Niklas Cassel (3):
>   ata: libata-sata: Save all fields from sense data descriptor
>   ata: libata-sata: Simplify sense_valid fetching
>   ata: libata-sata: Use BIT() macro to convert tag to bit field

Looks good. I will rebase for-6.16 on rc3 next Monday and apply 2/3 and 3/3.
Thanks !
Damien Le Moal April 21, 2025, 12:06 a.m. UTC | #2 
On 4/16/25 6:31 PM, Niklas Cassel wrote:
> Hello all,
> 
> Here comes some minor cleanups/fixes related to the sense_valid field in
> the Successful NCQ commands log.
> 
> 
> Kind regards,
> Niklas
> 
> 
> Changes since v2:
> -Picked up tags.
> -Changed "1ULL << tag" to "1 << tag" in patch 2/3 (Damien).
> -Improved subject in patch 3/3.
> 
> 
> Niklas Cassel (3):
>   ata: libata-sata: Save all fields from sense data descriptor
>   ata: libata-sata: Simplify sense_valid fetching
>   ata: libata-sata: Use BIT() macro to convert tag to bit field

Applied 2/3 and 3/3 to for-6.16. Thanks !