mbox series

[-next,V5,0/2] fix two bugs when trying rmmod sata_fsl

Message ID 20211126020307.2168767-1-libaokun1@huawei.com
Headers show
Series fix two bugs when trying rmmod sata_fsl | expand

Message

Baokun Li Nov. 26, 2021, 2:03 a.m. UTC 
V1->V2:
	Fixed the check on the return value of platform_get_irq().
	And propagate errors up to sata_fsl_probe()'s callers.
V2->V3:
	Add fixed and CC stable and modified the patch description.
V3->V4:
	Use a single structure.
V4->V5:
	Delete duplicate dev_err() message.

Baokun Li (2):
  sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
  sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl

 drivers/ata/sata_fsl.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

Comments

Damien Le Moal Nov. 26, 2021, 1:56 a.m. UTC | #1 
On 2021/11/26 11:03, Baokun Li wrote:
> V1->V2:
> 	Fixed the check on the return value of platform_get_irq().
> 	And propagate errors up to sata_fsl_probe()'s callers.
> V2->V3:
> 	Add fixed and CC stable and modified the patch description.
> V3->V4:
> 	Use a single structure.
> V4->V5:
> 	Delete duplicate dev_err() message.
> 
> Baokun Li (2):
>   sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
>   sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
> 
>  drivers/ata/sata_fsl.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
> 

The series looks good to me now.

Sergei ? Are you OK with it ?
Sergei Shtylyov Nov. 26, 2021, 7:27 p.m. UTC | #2 
Hello!

On 11/26/21 4:56 AM, Damien Le Moal wrote:

>> V1->V2:
>> 	Fixed the check on the return value of platform_get_irq().
>> 	And propagate errors up to sata_fsl_probe()'s callers.
>> V2->V3:
>> 	Add fixed and CC stable and modified the patch description.
>> V3->V4:
>> 	Use a single structure.
>> V4->V5:
>> 	Delete duplicate dev_err() message.
>>
>> Baokun Li (2):
>>   sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
>>   sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
>>
>>  drivers/ata/sata_fsl.c | 20 +++++++++++++-------
>>  1 file changed, 13 insertions(+), 7 deletions(-)
>>
> 
> The series looks good to me now.
> 
> Sergei ? Are you OK with it ?

   Yeah, I'll just give the patches by Reviewed-by's.

MBR, Sergei
Damien Le Moal Nov. 29, 2021, 11:38 a.m. UTC | #3 
On 2021/11/26 11:03, Baokun Li wrote:
> V1->V2:
> 	Fixed the check on the return value of platform_get_irq().
> 	And propagate errors up to sata_fsl_probe()'s callers.
> V2->V3:
> 	Add fixed and CC stable and modified the patch description.
> V3->V4:
> 	Use a single structure.
> V4->V5:
> 	Delete duplicate dev_err() message.
> 
> Baokun Li (2):
>   sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
>   sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
> 
>  drivers/ata/sata_fsl.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
> 

Applied to for-5.16-fixes. Thanks.