mbox series

[0/2] ide: Remove in_interrupt()

Message ID 20201113161021.2217361-1-bigeasy@linutronix.de
Headers show
Series ide: Remove in_interrupt() | expand

Message

Sebastian Andrzej Siewior Nov. 13, 2020, 4:10 p.m. UTC
In the discussion about preempt count consistency across kernel
configurations:

 https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/

it was concluded that the usage of in_interrupt() and related context
checks should be removed from non-core code.

This ide subsystem has two in_interrupts() checks before mutex/wait-event
invocations.

Sebastian

Comments

Jens Axboe Nov. 13, 2020, 4:25 p.m. UTC | #1
On 11/13/20 9:10 AM, Sebastian Andrzej Siewior wrote:
> In the discussion about preempt count consistency across kernel
> configurations:
> 
>  https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/
> 
> it was concluded that the usage of in_interrupt() and related context
> checks should be removed from non-core code.
> 
> This ide subsystem has two in_interrupts() checks before mutex/wait-event
> invocations.

Acked-by: Jens Axboe <axboe@kernel.dk>
Sebastian Andrzej Siewior Nov. 19, 2020, 4:51 p.m. UTC | #2
On 2020-11-13 09:25:08 [-0700], Jens Axboe wrote:
> On 11/13/20 9:10 AM, Sebastian Andrzej Siewior wrote:
> > In the discussion about preempt count consistency across kernel
> > configurations:
> > 
> >  https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/
> > 
> > it was concluded that the usage of in_interrupt() and related context
> > checks should be removed from non-core code.
> > 
> > This ide subsystem has two in_interrupts() checks before mutex/wait-event
> > invocations.
> 
> Acked-by: Jens Axboe <axboe@kernel.dk>

Andrew, are you okay with routing these two patches via your tree?

Sebastian
Andrew Morton Nov. 20, 2020, 1:26 a.m. UTC | #3
On Thu, 19 Nov 2020 17:51:33 +0100 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> On 2020-11-13 09:25:08 [-0700], Jens Axboe wrote:
> > On 11/13/20 9:10 AM, Sebastian Andrzej Siewior wrote:
> > > In the discussion about preempt count consistency across kernel
> > > configurations:
> > > 
> > >  https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/
> > > 
> > > it was concluded that the usage of in_interrupt() and related context
> > > checks should be removed from non-core code.
> > > 
> > > This ide subsystem has two in_interrupts() checks before mutex/wait-event
> > > invocations.
> > 
> > Acked-by: Jens Axboe <axboe@kernel.dk>
> 
> Andrew, are you okay with routing these two patches via your tree?

Sure, but I'm not subscribed to linux-ide.  Please resend, cc myself
and linux-kernel?