Message ID | 1520854838-21779-1-git-send-email-pchandru@nvidia.com |
---|---|
Headers | show |
Series | Refactor and add AHCI support for Tegra210 | expand |
On Mon, Mar 12, 2018 at 05:10:29PM +0530, Preetham Chandru Ramchandra wrote: > From: Preetham Ramchandra <pchandru@nvidia.com> > > 1. ADD AHCI support for Tegra210 > 2. Extend the Tegra AHCI controller device tree binding with Tegra210 > 3. Update initialization sequence > 4. Initialize regulators based on chip > 5. Disable DevSlp > 6. Disable DIPM All look good to me. How should the patches be routed? Thanks.
On Tue, Mar 13, 2018 at 02:06:33PM -0700, Tejun Heo wrote: > On Mon, Mar 12, 2018 at 05:10:29PM +0530, Preetham Chandru Ramchandra wrote: > > From: Preetham Ramchandra <pchandru@nvidia.com> > > > > 1. ADD AHCI support for Tegra210 > > 2. Extend the Tegra AHCI controller device tree binding with Tegra210 > > 3. Update initialization sequence > > 4. Initialize regulators based on chip > > 5. Disable DevSlp > > 6. Disable DIPM > > All look good to me. How should the patches be routed? My suggestion would be that I pick up the arm64 patches (2 and 3) into the Tegra tree and you take the rest (dt-bindings and driver changes) through libata? There are no dependencies between the two sets, other than maybe checkpatch.pl complaining about using an undocumented compatible string until both get merged into v4.17-rc1. I think that's fine, but we can be extra pedantic and carry patch 1 on a stable branch that is merged into both the libata and Tegra trees to avoid that warning. Thierry
On Mon, Mar 12, 2018 at 05:10:29PM +0530, Preetham Chandru Ramchandra wrote: > From: Preetham Ramchandra <pchandru@nvidia.com> > > 1. ADD AHCI support for Tegra210 > 2. Extend the Tegra AHCI controller device tree binding with Tegra210 > 3. Update initialization sequence > 4. Initialize regulators based on chip > 5. Disable DevSlp > 6. Disable DIPM > --- > > Preetham Ramchandra (9): > dt-bindings: Tegra210: add binding documentation > arm64: tegra: Add SATA node for Tegra210 > arm64: tegra: Enable AHCI on Jetson TX1 > ata: ahci_tegra: Update initialization sequence > ata: ahci_tegra: initialize regulators from soc struct > ata: ahci_tegra: disable devslp for Tegra124 > ata: ahci_tegra: disable DIPM > ata: ahci_tegra: Add AHCI support for Tegra210 > ata: change Tegra124 to Tegra > > .../bindings/ata/nvidia,tegra124-ahci.txt | 36 ++- > arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 5 + > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 16 + > drivers/ata/Kconfig | 4 +- > drivers/ata/ahci_tegra.c | 359 ++++++++++++++++----- > 5 files changed, 330 insertions(+), 90 deletions(-) The series, on Jetson TX1: Tested-by: Thierry Reding <treding@nvidia.com>
Hello, On Tue, Mar 13, 2018 at 11:42:59PM +0100, Thierry Reding wrote: > My suggestion would be that I pick up the arm64 patches (2 and 3) into > the Tegra tree and you take the rest (dt-bindings and driver changes) > through libata? There are no dependencies between the two sets, other > than maybe checkpatch.pl complaining about using an undocumented > compatible string until both get merged into v4.17-rc1. Applied 1, 4-9 to libata/for-4.17. Thanks a lot.
On Wed, Mar 14, 2018 at 08:25:13AM -0700, Tejun Heo wrote: > Hello, > > On Tue, Mar 13, 2018 at 11:42:59PM +0100, Thierry Reding wrote: > > My suggestion would be that I pick up the arm64 patches (2 and 3) into > > the Tegra tree and you take the rest (dt-bindings and driver changes) > > through libata? There are no dependencies between the two sets, other > > than maybe checkpatch.pl complaining about using an undocumented > > compatible string until both get merged into v4.17-rc1. > > Applied 1, 4-9 to libata/for-4.17. Patches 2 and 3 applied to for-4.17/arm64/dt. Thanks, Thierry
From: Preetham Ramchandra <pchandru@nvidia.com> 1. ADD AHCI support for Tegra210 2. Extend the Tegra AHCI controller device tree binding with Tegra210 3. Update initialization sequence 4. Initialize regulators based on chip 5. Disable DevSlp 6. Disable DIPM --- Preetham Ramchandra (9): dt-bindings: Tegra210: add binding documentation arm64: tegra: Add SATA node for Tegra210 arm64: tegra: Enable AHCI on Jetson TX1 ata: ahci_tegra: Update initialization sequence ata: ahci_tegra: initialize regulators from soc struct ata: ahci_tegra: disable devslp for Tegra124 ata: ahci_tegra: disable DIPM ata: ahci_tegra: Add AHCI support for Tegra210 ata: change Tegra124 to Tegra .../bindings/ata/nvidia,tegra124-ahci.txt | 36 ++- arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 5 + arch/arm64/boot/dts/nvidia/tegra210.dtsi | 16 + drivers/ata/Kconfig | 4 +- drivers/ata/ahci_tegra.c | 359 ++++++++++++++++----- 5 files changed, 330 insertions(+), 90 deletions(-)