| Message ID | ef38106b5099e92395d5cc84d1bf0b806b53d1dc.1764434226.git.ukleinek@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | fsi: Convert to bus probe mechanism | expand |
Hi Uwe, On Sat, Nov 29, 2025 at 05:57:40PM +0100, Uwe Kleine-König wrote: > Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()") whoever is going to apply the series needs to remember to replace this FIXME. > module_fsi_driver() cares about assigning the driver's bus member. Drop the > explicit driver specific assignment. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Thanks, Andi
Hello Andi, On Wed, Dec 03, 2025 at 06:07:11PM +0100, Andi Shyti wrote: > On Sat, Nov 29, 2025 at 05:57:40PM +0100, Uwe Kleine-König wrote: > > Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()") > > whoever is going to apply the series needs to remember to replace > this FIXME. Ah right, when I wrote the commit log I made a mental note to point that out in the cover letter, but then I forgot. Thanks for the reminder. Best regards Uwe
diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c index ae016a9431da..e98dd5dcac0f 100644 --- a/drivers/i2c/busses/i2c-fsi.c +++ b/drivers/i2c/busses/i2c-fsi.c @@ -763,7 +763,6 @@ static struct fsi_driver fsi_i2c_driver = { .id_table = fsi_i2c_ids, .drv = { .name = "i2c-fsi", - .bus = &fsi_bus_type, .probe = fsi_i2c_probe, .remove = fsi_i2c_remove, },
Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()") module_fsi_driver() cares about assigning the driver's bus member. Drop the explicit driver specific assignment. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> --- drivers/i2c/busses/i2c-fsi.c | 1 - 1 file changed, 1 deletion(-)