Message ID | CAJOps0smzC980mxpwqCtxbjCwzzU0ur4tm_f=mGH8t1PLPjPNA@mail.gmail.com |
---|---|
State | Superseded |
Headers | show |
Series | [RFC,1/2] i2c debug counters as sysfs attributes | expand |
On Tue, Oct 12, 2021 at 10:09 AM Tali Perry <tali.perry1@gmail.com> wrote: > On Tuesday, October 12, 2021 4:08 AM Sui Chen <suichen@google.com> wrote: > > This change adds npcm7xx debug counters as sysfs attributes using the i2c_adapter_stats_register_counter function. > > Signed-off-by: Sui Chen <suichen@google.com> > --- > drivers/i2c/busses/i2c-npcm7xx.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c > index 2ad166355ec9b..def044207cae2 100644 > --- a/drivers/i2c/busses/i2c-npcm7xx.c > +++ b/drivers/i2c/busses/i2c-npcm7xx.c > @@ -2224,6 +2224,14 @@ static void npcm_i2c_init_debugfs(struct platform_device *pdev, > debugfs_create_u64("rec_fail_cnt", 0444, d, &bus->rec_fail_cnt); > debugfs_create_u64("timeout_cnt", 0444, d, &bus->timeout_cnt); > > + /* register debug counters in sysfs */ > + i2c_adapter_stats_register_counter(&bus->adap, "ber_cnt", > + &bus->ber_cnt); i2c_adapter_stats_register_counter(&bus->adap, > + "nack_cnt", &bus->nack_cnt); > + i2c_adapter_stats_register_counter(&bus->adap, "rec_succ_cnt", > &bus->rec_succ_cnt); > + i2c_adapter_stats_register_counter(&bus->adap, "rec_fail_cnt", > &bus->rec_fail_cnt); > + i2c_adapter_stats_register_counter(&bus->adap, "timeout_cnt", > &bus->timeout_cnt); > + i2c_adapter_stats_register_counter(&bus->adap, "i2c_speed", > + &bus->bus_freq); > + > bus->debugfs = d; > } > > -- > 2.33.0.882.g93a45727a2-goog > Reviewed-by: Tali Perry <tali.perry1@gmail.com> Thanks for this patch! Tali Perry Nuvoton
diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c index 2ad166355ec9b..def044207cae2 100644 --- a/drivers/i2c/busses/i2c-npcm7xx.c +++ b/drivers/i2c/busses/i2c-npcm7xx.c @@ -2224,6 +2224,14 @@ static void npcm_i2c_init_debugfs(struct platform_device *pdev, debugfs_create_u64("rec_fail_cnt", 0444, d, &bus->rec_fail_cnt); debugfs_create_u64("timeout_cnt", 0444, d, &bus->timeout_cnt); + /* register debug counters in sysfs */ + i2c_adapter_stats_register_counter(&bus->adap, "ber_cnt", &bus->ber_cnt); + i2c_adapter_stats_register_counter(&bus->adap, "nack_cnt", &bus->nack_cnt); + i2c_adapter_stats_register_counter(&bus->adap, "rec_succ_cnt", &bus->rec_succ_cnt); + i2c_adapter_stats_register_counter(&bus->adap, "rec_fail_cnt", &bus->rec_fail_cnt); + i2c_adapter_stats_register_counter(&bus->adap, "timeout_cnt", &bus->timeout_cnt); + i2c_adapter_stats_register_counter(&bus->adap, "i2c_speed", &bus->bus_freq);
This change adds npcm7xx debug counters as sysfs attributes using the i2c_adapter_stats_register_counter function. Signed-off-by: Sui Chen <suichen@google.com> --- drivers/i2c/busses/i2c-npcm7xx.c | 8 ++++++++ 1 file changed, 8 insertions(+) + bus->debugfs = d; }