From patchwork Wed Nov 22 21:12:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 840521 X-Patchwork-Delegate: bartekgola@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o4zvVIbN"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yhwCw1CXmz9rxm for ; Thu, 23 Nov 2017 08:13:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751611AbdKVVNN (ORCPT ); Wed, 22 Nov 2017 16:13:13 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:39882 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbdKVVNL (ORCPT ); Wed, 22 Nov 2017 16:13:11 -0500 Received: by mail-wr0-f195.google.com with SMTP id 11so12443561wrb.6 for ; Wed, 22 Nov 2017 13:13:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=KzjrZeSBoGCKKusTaiHIDIoEs4tHWpUi2XH47hHbE60=; b=o4zvVIbNfpPGFH4xLhYiyOlIygI6kajKeVMrFoES6jY/3Abn2DEOXn9NI3mylMTJqz A8MYXQS+7masF2gRw31nip9FYOjhk96MqjfGyTqzLXJxGXJsJ4Kjv/nT/xsYxI87gTkr xpsvW1ZRlg0vT4RMZwQS+QvFwjenRSSeo71ZeOq0UW3ED8ROp78pSTWbeH2Wg52VR05m XvNv7xOAen2DBKmcCzJg2qPobZNXs2q+RydZT6sGGQgQWGvVnWRzaJYgAQOnRG/WdXGC 7l6FHtv9FFk87jzBu3fjKULZCQTk7rQt2EzLayeU5pbzdI7ijh0iq94yixuuQtrky68b N6Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=KzjrZeSBoGCKKusTaiHIDIoEs4tHWpUi2XH47hHbE60=; b=Eqk1GPV97lSc5T6Cl6LGXgbW9DeYptnbHoYMDeN8DYhuoRqtj4csVSybhZlv1bqfR+ GTR8EFkJUuD6GmB+FgECzfeDATMdJlnrtKZ23tc6/Wb3v339S8cEpwyaqUYZf851QC5L G2jbNUT4iLmSYo85LwjGtGbjW2FpoO7SYcbLOh7R1DPf9M5mw/29gLyon2hI3rN/vxOo 7EIl8KfQjnrh9I27xdcUvTd0rWuYXWVlZCKM3aq32khUXygJgfhRudlP/BaIb5t7eCux 1sEwhkRZEV03CfdeseP7tKqEavmsxgL1IsdDcjXvOcqINO3UsVD4LLAj8Eygb7ZhAEhV jwqA== X-Gm-Message-State: AJaThX6Xk4qz769a3L8oKsqkk86sWzISv9PXZLFQsEEfuCexj/SgOqW/ BqehTVSkazPa82ekv+riZKcmrg== X-Google-Smtp-Source: AGs4zMaDJdQaTnObn95KMhZSEKTeId3OBj+VagUNVhrewWqAi1z7boU7MDRxFFxolol9+K2XRrpXDA== X-Received: by 10.223.183.17 with SMTP id l17mr20262280wre.1.1511385189587; Wed, 22 Nov 2017 13:13:09 -0800 (PST) Received: from ?IPv6:2003:ea:8bc0:e400:58ac:8788:9665:db13? (p200300EA8BC0E40058AC87889665DB13.dip0.t-ipconnect.de. [2003:ea:8bc0:e400:58ac:8788:9665:db13]) by smtp.googlemail.com with ESMTPSA id f132sm3660659wmf.17.2017.11.22.13.13.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Nov 2017 13:13:09 -0800 (PST) From: Heiner Kallweit Subject: [PATCH v4 3/7] eeprom: at24: add regmap-based write function To: Bartosz Golaszewski Cc: "linux-i2c@vger.kernel.org" References: <0448eec2-7dfb-ca79-d03a-d5b7fcb5d76c@gmail.com> Message-ID: <81dfdad5-562c-665c-a749-e785d3da7189@gmail.com> Date: Wed, 22 Nov 2017 22:12:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <0448eec2-7dfb-ca79-d03a-d5b7fcb5d76c@gmail.com> Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Add a regmap-based write function. Signed-off-by: Heiner Kallweit --- v2: - rebased v3: - improve readability - re-introduce debug message v4: - no changes --- drivers/misc/eeprom/at24.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index fe4393ad6..86a36482a 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -537,6 +537,31 @@ static ssize_t at24_eeprom_write_smbus_byte(struct at24_data *at24, return -ETIMEDOUT; } +static ssize_t at24_regmap_write(struct at24_data *at24, const char *buf, + unsigned int offset, size_t count) +{ + unsigned long timeout, write_time; + struct at24_client *at24_client; + struct i2c_client *client; + struct regmap *regmap; + int ret; + + at24_client = at24_translate_offset(at24, &offset); + regmap = at24_client->regmap; + client = at24_client->client; + count = at24_adjust_write_count(at24, offset, count); + + loop_until_timeout(timeout, write_time) { + ret = regmap_bulk_write(regmap, offset, buf, count); + dev_dbg(&client->dev, "write %zu@%d --> %d (%ld)\n", + count, offset, ret, jiffies); + if (!ret) + return count; + } + + return -ETIMEDOUT; +} + static ssize_t at24_eeprom_write_i2c(struct at24_data *at24, const char *buf, unsigned int offset, size_t count) { @@ -654,7 +679,7 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count) while (count) { int status; - status = at24->write_func(at24, buf, off, count); + status = at24_regmap_write(at24, buf, off, count); if (status < 0) { mutex_unlock(&at24->lock); pm_runtime_put(&client->dev);