| Message ID | 3888f892b8c4d8c8acd17e56581e726ace7f7092.1746536495.git.geert+renesas@glider.be |
|---|---|
| State | Accepted |
| Delegated to: | Andi Shyti |
| Headers | show |
| Series | i2c: I2C_DESIGNWARE_AMDISP should depend on DRM_AMD_ISP | expand |
Hi Geert, Thanks for your patch. On 5/6/2025 9:02 AM, Geert Uytterhoeven wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > The AMD Image Signal Processor I2C functionality is only present on AMD > platforms with ISP support, and its platform device is instantiated by > the AMD ISP driver. Hence add a dependency on DRM_AMD_ISP, to prevent > asking the user about this driver when configuring a kernel that does > not support the AMD ISP. > > Fixes: 63f0545cb1bf0840 ("i2c: amd-isp: Add ISP i2c-designware driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/i2c/busses/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 865b760866ef42ba..7c348491e1bbac7c 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -594,6 +594,7 @@ config I2C_DESIGNWARE_PLATFORM > > config I2C_DESIGNWARE_AMDISP > tristate "Synopsys DesignWare Platform for AMDISP" > + depends on DRM_AMD_ISP || COMPILE_TEST > depends on I2C_DESIGNWARE_CORE > help > If you say yes to this option, support will be included for the > -- > 2.43.0 > LGTM. Reviewed-by: Pratap Nirujogi <pratap.nirujogi@amd.com> Thanks, Pratap
Hi Geert, On Tue, May 06, 2025 at 03:02:06PM +0200, Geert Uytterhoeven wrote: > The AMD Image Signal Processor I2C functionality is only present on AMD > platforms with ISP support, and its platform device is instantiated by > the AMD ISP driver. Hence add a dependency on DRM_AMD_ISP, to prevent > asking the user about this driver when configuring a kernel that does > not support the AMD ISP. > > Fixes: 63f0545cb1bf0840 ("i2c: amd-isp: Add ISP i2c-designware driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> merged to i2c/i2c-host. Thanks, Andi
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 865b760866ef42ba..7c348491e1bbac7c 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -594,6 +594,7 @@ config I2C_DESIGNWARE_PLATFORM config I2C_DESIGNWARE_AMDISP tristate "Synopsys DesignWare Platform for AMDISP" + depends on DRM_AMD_ISP || COMPILE_TEST depends on I2C_DESIGNWARE_CORE help If you say yes to this option, support will be included for the
The AMD Image Signal Processor I2C functionality is only present on AMD platforms with ISP support, and its platform device is instantiated by the AMD ISP driver. Hence add a dependency on DRM_AMD_ISP, to prevent asking the user about this driver when configuring a kernel that does not support the AMD ISP. Fixes: 63f0545cb1bf0840 ("i2c: amd-isp: Add ISP i2c-designware driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/i2c/busses/Kconfig | 1 + 1 file changed, 1 insertion(+)