| Message ID | 20250623203144007kQF7E1Bhy5PJl-Ph3u3Ou@zte.com.cn |
|---|---|
| State | Accepted |
| Delegated to: | Andi Shyti |
| Headers | show |
| Series | PATCH] i2c: stm32f7: Use str_on_off() helper | expand |
Hi, thank you for your patch. On Mon, Jun 23, 2025 at 08:31:44PM +0800, long.yunjian@zte.com.cn wrote: > From: Yumeng Fang <fang.yumeng@zte.com.cn> > > Remove hard-coded strings by using the str_on_off() helper. > > Signed-off-by: Yumeng Fang <fang.yumeng@zte.com.cn> > --- > drivers/i2c/busses/i2c-stm32f7.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index e4aaeb2262d0..ef15475a7ee1 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -34,6 +34,7 @@ > #include <linux/regmap.h> > #include <linux/reset.h> > #include <linux/slab.h> > +#include <linux/string_choices.h> > > #include "i2c-stm32.h" > > @@ -722,7 +723,7 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, > dev_dbg(i2c_dev->dev, "I2C Rise(%i) and Fall(%i) Time\n", > setup->rise_time, setup->fall_time); > dev_dbg(i2c_dev->dev, "I2C Analog Filter(%s), DNF(%i)\n", > - (i2c_dev->analog_filter ? "On" : "Off"), i2c_dev->dnf); > + str_on_off(i2c_dev->analog_filter), i2c_dev->dnf); > > i2c_dev->bus_rate = setup->speed_freq; > Acked-by: Alain Volmat <alain.volmat@foss.st.com> Regards, Alain > -- > 2.25.1
Hi Yumeng, On Mon, Jun 23, 2025 at 08:31:44PM +0800, long.yunjian@zte.com.cn wrote: > From: Yumeng Fang <fang.yumeng@zte.com.cn> > > Remove hard-coded strings by using the str_on_off() helper. > > Signed-off-by: Yumeng Fang <fang.yumeng@zte.com.cn> merged to i2c/i2c-host. Thanks, Andi
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index e4aaeb2262d0..ef15475a7ee1 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -34,6 +34,7 @@ #include <linux/regmap.h> #include <linux/reset.h> #include <linux/slab.h> +#include <linux/string_choices.h> #include "i2c-stm32.h" @@ -722,7 +723,7 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, dev_dbg(i2c_dev->dev, "I2C Rise(%i) and Fall(%i) Time\n", setup->rise_time, setup->fall_time); dev_dbg(i2c_dev->dev, "I2C Analog Filter(%s), DNF(%i)\n", - (i2c_dev->analog_filter ? "On" : "Off"), i2c_dev->dnf); + str_on_off(i2c_dev->analog_filter), i2c_dev->dnf); i2c_dev->bus_rate = setup->speed_freq;