| Message ID | 20240410112418.6400-30-wsa+renesas@sang-engineering.com |
|---|---|
| State | Accepted |
| Headers | show
Return-Path: <linux-i2c+bounces-2861-incoming=patchwork.ozlabs.org@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=LndvGka0; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org; envelope-from=linux-i2c+bounces-2861-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VF0ss66G9z1yYM for <incoming@patchwork.ozlabs.org>; Wed, 10 Apr 2024 21:27:13 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9858D1C20E55 for <incoming@patchwork.ozlabs.org>; Wed, 10 Apr 2024 11:27:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0073415959B; Wed, 10 Apr 2024 11:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="LndvGka0" X-Original-To: linux-i2c@vger.kernel.org Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A47AD15D5A2 for <linux-i2c@vger.kernel.org>; Wed, 10 Apr 2024 11:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748318; cv=none; b=cWwm9NK+VY7cONLZNwOmQHiq4snCR7a1AKUi6Rjyx/cdLhmjDLGKKmPymzqev7OTnBbQF6w23NQdRA5kR+c0rq1VKZxXSqD+ZOPIRX7mYN/ZdTa06tNeaLHK3nWe36oceU8hUnMiv4Xea+qUZPKr3UaEnd6qlxzY76N4jKi0MNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712748318; c=relaxed/simple; bh=xQvUs1HAINisoxCUqYyynmQYCCX1o0BOa+VKS52/pn8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UtRFDN7Jo133xYEdbO8UecQshDLgUpK9ZYyCBNfVoQ9Gt9B9WKVVjWExGqDKdMMpboMpRel1bDfOzndLdhQ28yKYQFtf0pJ83UwSvRd/AaDJMDfyA5+BcSSNmDFAyatp2J/vg0P2nTryH3BmQfTlyRzF6c6PVMEj6OYEhvJG/CI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=LndvGka0; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=NWNvhOQ1P1l2OPQ/ikbk/yVi9ub/Dsp7Etl7kO7Xtms=; b=LndvGk a09V581tPWlWHw0Nn3N/rn2lMHLvDSseKEe/RL8R3wS7xyMWuNxZ+yfs/0pfsSny rTNWkdh//T9P7OK1KhPmr9NOTz2tPhCStjoqeldajfBIgwHMoBz2CWDzyOpmsSDB 9kUKl/aTVwj3bTzsTx5b6igiXvJ06zjliEa8JhkuVxo/fs+Ct664NUFbikR6OVGh CN/NKSAMRgAm+9KSZuPBvJJVHaYxIH3vf4jsYdN6HvRV8DEIEhtefH6JhWUux8Ko RqwaET2H0+KEV9xPKTAjTkpNXgygoit4zgL/md4dN6SJndDlAUPCyIAcX37DFPzw dQPg4Z31mECCwYxA== Received: (qmail 521623 invoked from network); 10 Apr 2024 13:25:09 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:09 +0200 X-UD-Smtp-Session: l3s3148p1@ndCNSrwVqwhtKPEL From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-i2c@vger.kernel.org Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>, Tony Lindgren <tony@atomide.com>, Aaro Koskinen <aaro.koskinen@iki.fi>, Janusz Krzysztofik <jmkrzyszt@gmail.com>, Vignesh R <vigneshr@ti.com>, Andi Shyti <andi.shyti@kernel.org>, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/18] i2c: omap: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:24 +0200 Message-ID: <20240410112418.6400-30-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: <linux-i2c.vger.kernel.org> List-Subscribe: <mailto:linux-i2c+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-i2c+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit |
| Series |
i2c: remove printout on handled timeouts
|
expand
|
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 42165ef57946..36bebef36740 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -752,7 +752,6 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, } if (timeout == 0) { - dev_err(omap->dev, "controller timed out\n"); omap_i2c_reset(omap); __omap_i2c_init(omap); return -ETIMEDOUT;
I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/busses/i2c-omap.c | 1 - 1 file changed, 1 deletion(-)