[09/33] fsi: core: Add slave error trace

Message ID	20240215220759.976998-10-eajames@linux.ibm.com
State	Not Applicable
Headers	show Return-Path: <linux-i2c+bounces-1775-incoming=patchwork.ozlabs.org@vger.kernel.org> From: Eddie James <eajames@linux.ibm.com> To: linux-fsi@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, andi.shyti@kernel.org, eajames@linux.ibm.com, alistair@popple.id.au, joel@jms.id.au, jk@ozlabs.org, sboyd@kernel.org, mturquette@baylibre.com, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Subject: [PATCH 09/33] fsi: core: Add slave error trace Date: Thu, 15 Feb 2024 16:07:35 -0600 Message-Id: <20240215220759.976998-10-eajames@linux.ibm.com> In-Reply-To: <20240215220759.976998-1-eajames@linux.ibm.com> References: <20240215220759.976998-1-eajames@linux.ibm.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	fsi: Interrupt support \| expand [00/33] fsi: Interrupt support [01/33] dt-bindings: clock: ast2600: Add FSI clock [02/33] clk: ast2600: Add FSI parent clock with correct rate [03/33] fsi: Move slave definitions to fsi-slave.h [04/33] fsi: Improve master indexing [05/33] fsi: Use a defined value for default echo delay [06/33] fsi: Expose master-specific local bus clock divider [07/33] ARM: dts: aspeed: p10 and tacoma: Set FSI clock frequency [08/33] fsi: core: Improve master read/write/error traces [09/33] fsi: core: Add slave error trace [10/33] fsi: aspeed: Add AST2700 support [11/33] fsi: core: Add slave spinlock [12/33] fsi: core: Allow cfam device type aliases [13/33] fsi: core: Add common regmap master functions [14/33] fsi: hub: Use common initialization and link enable [15/33] fsi: aspeed: Use common initialization and link enable [16/33] fsi: aspeed: Remove cfam reset sysfs file in error path and remove [17/33] fsi: aspeed: Refactor trace functions [18/33] fsi: aspeed: Don't clear all IRQs during OPB transfers [19/33] fsi: aspeed: Only read result register for successful read [20/33] fsi: aspeed: Switch to spinlock [21/33] fsi: aspeed: Disable relative addressing and IPOLL for cfam reset [22/33] fsi: aspeed: Use common master error handler [23/33] fsi: core: Add interrupt support [24/33] fsi: aspeed: Add interrupt support [25/33] fsi: hub: Add interrupt support [26/33] ARM: dts: aspeed: FSI interrupt support [27/33] i2c: fsi: Calculate clock divider from local bus frequency [28/33] i2c: fsi: Improve formatting [29/33] i2c: fsi: Change fsi_i2c_write_reg to accept data instead of a pointer [30/33] i2c: fsi: Remove list structure of ports [31/33] i2c: fsi: Define a function to check status error bits [32/33] i2c: fsi: Add boolean for skip stop command on abort [33/33] i2c: fsi: Add interrupt support

Message ID

20240215220759.976998-10-eajames@linux.ibm.com

State

Not Applicable

Headers

From: Eddie James <eajames@linux.ibm.com>
To: linux-fsi@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        andi.shyti@kernel.org, eajames@linux.ibm.com, alistair@popple.id.au,
        joel@jms.id.au, jk@ozlabs.org, sboyd@kernel.org,
        mturquette@baylibre.com, robh@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Subject: [PATCH 09/33] fsi: core: Add slave error trace
Date: Thu, 15 Feb 2024 16:07:35 -0600
Message-Id: <20240215220759.976998-10-eajames@linux.ibm.com>
In-Reply-To: <20240215220759.976998-1-eajames@linux.ibm.com>
References: <20240215220759.976998-1-eajames@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

fsi: Interrupt support | expand

Commit Message

Eddie James Feb. 15, 2024, 10:07 p.m. UTC

Trace out the FSI slave status and interrupt status.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
 drivers/fsi/fsi-core.c     |  1 +
 include/trace/events/fsi.h | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index a989a2007c0f..e6ed2d0773b6 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -185,6 +185,7 @@  static int fsi_slave_report_and_clear_errors(struct fsi_slave *slave)
 
 	dev_dbg(&slave->dev, "status: 0x%08x, sisc: 0x%08x\n",
 			be32_to_cpu(stat), be32_to_cpu(irq));
+	trace_fsi_slave_error(slave, be32_to_cpu(irq), be32_to_cpu(stat));
 
 	/* clear interrupts */
 	return fsi_master_write(master, link, id, FSI_SLAVE_BASE + FSI_SISC,
diff --git a/include/trace/events/fsi.h b/include/trace/events/fsi.h
index fed8835f438e..5509afc98ee8 100644
--- a/include/trace/events/fsi.h
+++ b/include/trace/events/fsi.h
@@ -115,6 +115,25 @@  TRACE_EVENT(fsi_master_unregister,
 	TP_printk("fsi%d (%d links)", __entry->master_idx, __entry->n_links)
 );
 
+TRACE_EVENT(fsi_slave_error,
+	TP_PROTO(const struct fsi_slave *slave, uint32_t sisc, uint32_t sstat),
+	TP_ARGS(slave, sisc, sstat),
+	TP_STRUCT__entry(
+		__field(int, master_idx)
+		__field(int, link)
+		__field(uint32_t, sisc)
+		__field(uint32_t, sstat)
+	),
+	TP_fast_assign(
+		__entry->master_idx = slave->master->idx;
+		__entry->link = slave->link;
+		__entry->sisc = sisc;
+		__entry->sstat = sstat;
+	),
+	TP_printk("fsi%d:%02d sisc:%08x sstat:%08x", __entry->master_idx, __entry->link,
+		  __entry->sisc, __entry->sstat)
+);
+
 TRACE_EVENT(fsi_slave_init,
 	TP_PROTO(const struct fsi_slave *slave),
 	TP_ARGS(slave),

[09/33] fsi: core: Add slave error trace

Commit Message

Patch