| Message ID | 20240131141653.2689260-6-jarkko.nikula@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i2c: designware: Generic polling mode code | expand |
On Wed, Jan 31, 2024 at 04:16:51PM +0200, Jarkko Nikula wrote: > I believe RX FIFO depth define 0 is incorrect on Wangxun 10Gb NIC. It > must be at least 1 since code is able to read received data from the > DW_IC_DATA_CMD register. > > For now this define is irrelevant since the txgbe_i2c_dw_xfer_quirk() > doesn't use the rx_fifo_depth member variable of struct dw_i2c_dev but > is needed when converting code into generic polling mode implementation. Shouldn't this formally have a Fixes tag?
On 2/1/24 13:59, Andy Shevchenko wrote: > On Wed, Jan 31, 2024 at 04:16:51PM +0200, Jarkko Nikula wrote: >> I believe RX FIFO depth define 0 is incorrect on Wangxun 10Gb NIC. It >> must be at least 1 since code is able to read received data from the >> DW_IC_DATA_CMD register. >> >> For now this define is irrelevant since the txgbe_i2c_dw_xfer_quirk() >> doesn't use the rx_fifo_depth member variable of struct dw_i2c_dev but >> is needed when converting code into generic polling mode implementation. > > Shouldn't this formally have a Fixes tag? > I don't think so since this define is not in use before my last patch. May needlessly bother stable bot & folks.
diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index 4d277ebcca92..bf8f140dc113 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -319,7 +319,7 @@ struct dw_i2c_dev { #define AMD_UCSI_INTR_EN 0xd #define TXGBE_TX_FIFO_DEPTH 4 -#define TXGBE_RX_FIFO_DEPTH 0 +#define TXGBE_RX_FIFO_DEPTH 1 struct i2c_dw_semaphore_callbacks { int (*probe)(struct dw_i2c_dev *dev);
I believe RX FIFO depth define 0 is incorrect on Wangxun 10Gb NIC. It must be at least 1 since code is able to read received data from the DW_IC_DATA_CMD register. For now this define is irrelevant since the txgbe_i2c_dw_xfer_quirk() doesn't use the rx_fifo_depth member variable of struct dw_i2c_dev but is needed when converting code into generic polling mode implementation. Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> --- drivers/i2c/busses/i2c-designware-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)