Message ID | 20230516080553.427681-1-alexander.stein@ew.tq-group.com |
---|---|
State | Accepted |
Delegated to: | Bartosz Golaszewski |
Headers | show |
Series | [1/1] eeprom: at24: Use dev_err_probe for nvmem register failure | expand |
On Tue, May 16, 2023 at 10:05 AM Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > > When using nvmem layouts it is possible devm_nvmem_register returns > -EPROBE_DEFER, resulting in an 'empty' in > /sys/kernel/debug/devices_deferred. Use dev_err_probe for providing > additional information. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > drivers/misc/eeprom/at24.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > index 938c4f41b98c..5aae2f9bdd51 100644 > --- a/drivers/misc/eeprom/at24.c > +++ b/drivers/misc/eeprom/at24.c > @@ -761,7 +761,8 @@ static int at24_probe(struct i2c_client *client) > pm_runtime_disable(dev); > if (!pm_runtime_status_suspended(dev)) > regulator_disable(at24->vcc_reg); > - return PTR_ERR(at24->nvmem); > + return dev_err_probe(dev, PTR_ERR(at24->nvmem), > + "failed to register nvmem\n"); > } > > /* > -- > 2.34.1 > Applied, thanks! Bartosz
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 938c4f41b98c..5aae2f9bdd51 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -761,7 +761,8 @@ static int at24_probe(struct i2c_client *client) pm_runtime_disable(dev); if (!pm_runtime_status_suspended(dev)) regulator_disable(at24->vcc_reg); - return PTR_ERR(at24->nvmem); + return dev_err_probe(dev, PTR_ERR(at24->nvmem), + "failed to register nvmem\n"); } /*
When using nvmem layouts it is possible devm_nvmem_register returns -EPROBE_DEFER, resulting in an 'empty' in /sys/kernel/debug/devices_deferred. Use dev_err_probe for providing additional information. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/misc/eeprom/at24.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)