| Message ID | 20230508205306.1474415-88-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | i2c: Convert to platform remove callback returning void | expand |
> -----Original Message----- > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Sent: Monday, 8 May 2023 23:53 > To: Vadim Pasternak <vadimp@nvidia.com>; Michael Shych > <michaelsh@nvidia.com>; Peter Rosin <peda@axentia.se>; Wolfram Sang > <wsa@kernel.org> > Cc: linux-i2c@vger.kernel.org; kernel@pengutronix.de > Subject: [PATCH 87/89] i2c: mux: mlxcpld: Convert to platform remove > callback returning void > > The .remove() callback for a platform driver returns an int which makes many > driver authors wrongly assume it's possible to do error handling by returning > an error code. However the value returned is (mostly) ignored and this > typically results in resource leaks. To improve here there is a quest to make > the remove callback return void. In the first step of this quest all drivers are > converted to .remove_new() which already returns void. > > Trivially convert this driver from always returning zero in the remove callback > to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Vadim Pasternak <vadimp@nvidia.com> > --- > drivers/i2c/muxes/i2c-mux-mlxcpld.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/muxes/i2c-mux-mlxcpld.c b/drivers/i2c/muxes/i2c- > mux-mlxcpld.c > index 1a879f6a31ef..3dda00f1df78 100644 > --- a/drivers/i2c/muxes/i2c-mux-mlxcpld.c > +++ b/drivers/i2c/muxes/i2c-mux-mlxcpld.c > @@ -170,12 +170,11 @@ static int mlxcpld_mux_probe(struct > platform_device *pdev) > return err; > } > > -static int mlxcpld_mux_remove(struct platform_device *pdev) > +static void mlxcpld_mux_remove(struct platform_device *pdev) > { > struct i2c_mux_core *muxc = platform_get_drvdata(pdev); > > i2c_mux_del_adapters(muxc); > - return 0; > } > > static struct platform_driver mlxcpld_mux_driver = { @@ -183,7 +182,7 @@ > static struct platform_driver mlxcpld_mux_driver = { > .name = "i2c-mux-mlxcpld", > }, > .probe = mlxcpld_mux_probe, > - .remove = mlxcpld_mux_remove, > + .remove_new = mlxcpld_mux_remove, > }; > > module_platform_driver(mlxcpld_mux_driver); > -- > 2.39.2
2023-05-08 at 22:53, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Peter Rosin <peda@axentia.se> Cheers, Peter
diff --git a/drivers/i2c/muxes/i2c-mux-mlxcpld.c b/drivers/i2c/muxes/i2c-mux-mlxcpld.c index 1a879f6a31ef..3dda00f1df78 100644 --- a/drivers/i2c/muxes/i2c-mux-mlxcpld.c +++ b/drivers/i2c/muxes/i2c-mux-mlxcpld.c @@ -170,12 +170,11 @@ static int mlxcpld_mux_probe(struct platform_device *pdev) return err; } -static int mlxcpld_mux_remove(struct platform_device *pdev) +static void mlxcpld_mux_remove(struct platform_device *pdev) { struct i2c_mux_core *muxc = platform_get_drvdata(pdev); i2c_mux_del_adapters(muxc); - return 0; } static struct platform_driver mlxcpld_mux_driver = { @@ -183,7 +182,7 @@ static struct platform_driver mlxcpld_mux_driver = { .name = "i2c-mux-mlxcpld", }, .probe = mlxcpld_mux_probe, - .remove = mlxcpld_mux_remove, + .remove_new = mlxcpld_mux_remove, }; module_platform_driver(mlxcpld_mux_driver);
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/i2c/muxes/i2c-mux-mlxcpld.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)