diff mbox series

[3/5] i2c: qcom-cci:Use devm_platform_get_and_ioremap_resource()

Message ID 20230306144522.15699-1-quic_mdalam@quicinc.com
State Accepted
Headers show
Series None | expand

Commit Message

Md Sadre Alam March 6, 2023, 2:45 p.m. UTC 
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---
 drivers/i2c/busses/i2c-qcom-cci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Wolfram Sang June 7, 2023, 10:34 a.m. UTC | #1 
On Mon, Mar 06, 2023 at 08:15:22PM +0530, Md Sadre Alam wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>

Loic, Robert, do you agree with this patch?
Robert Foss June 7, 2023, 12:25 p.m. UTC | #2 
On Wed, Jun 7, 2023 at 12:34 PM Wolfram Sang <wsa@kernel.org> wrote:
>
> On Mon, Mar 06, 2023 at 08:15:22PM +0530, Md Sadre Alam wrote:
> > Convert platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.
> >
> > Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
>
> Loic, Robert, do you agree with this patch?
>

Acked-by: Robert Foss <rfoss@kernel.org>
Wolfram Sang June 8, 2023, 7:26 p.m. UTC | #3 
On Mon, Mar 06, 2023 at 08:15:22PM +0530, Md Sadre Alam wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>

Applied to for-next, thanks! Also, thanks, Robert.
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index 01358472680c..ed70bc1e4926 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -581,8 +581,7 @@  static int cci_probe(struct platform_device *pdev)
 
 	/* Memory */
 
-	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	cci->base = devm_ioremap_resource(dev, r);
+	cci->base = devm_platform_get_and_ioremap_resource(pdev, 0, &r);
 	if (IS_ERR(cci->base))
 		return PTR_ERR(cci->base);