diff mbox series

i2c: s3c2410: fix returnvar.cocci warning

Message ID 20220506073134.6544-1-hanyihao@vivo.com
State Superseded
Headers show
Series i2c: s3c2410: fix returnvar.cocci warning | expand

Commit Message

Yihao Han May 6, 2022, 7:31 a.m. UTC 
Fix the following coccicheck warning:

drivers/i2c/busses/i2c-s3c2410.c:388:5-8: Unneeded variable: "ret".
Return "0" on line 551

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/i2c/busses/i2c-s3c2410.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Krzysztof Kozlowski May 6, 2022, 7:52 a.m. UTC | #1 
On 06/05/2022 09:31, Yihao Han wrote:
> Fix the following coccicheck warning:
> 
> drivers/i2c/busses/i2c-s3c2410.c:388:5-8: Unneeded variable: "ret".
> Return "0" on line 551
> 
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
>  drivers/i2c/busses/i2c-s3c2410.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

This was already reported:
https://lore.kernel.org/all/0d1a0027-e74d-9f07-3b96-372b5ca14ae3@canonical.com/

Please apply instead my previous suggestion.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index b49a1b170bb2..6df85b23156c 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -385,7 +385,6 @@  static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
 {
 	unsigned long tmp;
 	unsigned char byte;
-	int ret = 0;
 
 	switch (i2c->state) {
 
@@ -548,7 +547,7 @@  static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
 	tmp &= ~S3C2410_IICCON_IRQPEND;
 	writel(tmp, i2c->regs + S3C2410_IICCON);
  out:
-	return ret;
+	return 0;
 }
 
 /*