| Message ID | 20220220035321.3870-9-warp5tw@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | i2c: npcm: Bug fixes timeout, spurious interrupts | expand |
On Sun, Feb 20, 2022 at 11:53:18AM +0800, Tyrone Ting wrote: > From: Tyrone Ting <kfting@nuvoton.com> > > Use ioread8 instead of ioread32 to access the SMBnCTL3 register since > the register is only 8-bit wide. > > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") > Signed-off-by: Tyrone Ting <kfting@nuvoton.com> > Signed-off-by: Tali Perry <tali.perry1@gmail.com> > --- > drivers/i2c/busses/i2c-npcm7xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c > index ee4757eff4b3..4715afcf9ac4 100644 > --- a/drivers/i2c/busses/i2c-npcm7xx.c > +++ b/drivers/i2c/busses/i2c-npcm7xx.c > @@ -360,14 +360,14 @@ static int npcm_i2c_get_SCL(struct i2c_adapter *_adap) > { > struct npcm_i2c *bus = container_of(_adap, struct npcm_i2c, adap); > > - return !!(I2CCTL3_SCL_LVL & ioread32(bus->reg + NPCM_I2CCTL3)); > + return !!(I2CCTL3_SCL_LVL & ioread8(bus->reg + NPCM_I2CCTL3)); > } > > static int npcm_i2c_get_SDA(struct i2c_adapter *_adap) > { > struct npcm_i2c *bus = container_of(_adap, struct npcm_i2c, adap); > > - return !!(I2CCTL3_SDA_LVL & ioread32(bus->reg + NPCM_I2CCTL3)); > + return !!(I2CCTL3_SDA_LVL & ioread8(bus->reg + NPCM_I2CCTL3)); > } > > static inline u16 npcm_i2c_get_index(struct npcm_i2c *bus) Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Thanks, Jonathan
diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c index ee4757eff4b3..4715afcf9ac4 100644 --- a/drivers/i2c/busses/i2c-npcm7xx.c +++ b/drivers/i2c/busses/i2c-npcm7xx.c @@ -360,14 +360,14 @@ static int npcm_i2c_get_SCL(struct i2c_adapter *_adap) { struct npcm_i2c *bus = container_of(_adap, struct npcm_i2c, adap); - return !!(I2CCTL3_SCL_LVL & ioread32(bus->reg + NPCM_I2CCTL3)); + return !!(I2CCTL3_SCL_LVL & ioread8(bus->reg + NPCM_I2CCTL3)); } static int npcm_i2c_get_SDA(struct i2c_adapter *_adap) { struct npcm_i2c *bus = container_of(_adap, struct npcm_i2c, adap); - return !!(I2CCTL3_SDA_LVL & ioread32(bus->reg + NPCM_I2CCTL3)); + return !!(I2CCTL3_SDA_LVL & ioread8(bus->reg + NPCM_I2CCTL3)); } static inline u16 npcm_i2c_get_index(struct npcm_i2c *bus)