| Message ID | 20220214124701.105814-1-yang.lee@linux.alibaba.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next,v2,RESEND] i2c: designware: remove unneeded semicolon | expand |
Hi On 2/14/22 14:47, Yang Li wrote: > Eliminate the following coccicheck warnings: > ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon > ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > > --Changes in v2: > According to Jan's suggestion > Fix the same problem in check_i2c_req_sts() function. > > drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > For future contributions: Technically this would be v3 rather than v2 RESEND since you fixed the typo in commit log noted by Jan for v2. Please use RESEND only if you'll send exactly the same version for instance if you didn't receive any comments for several weeks or some recipient was missing from Cc field. I believe Jan will give Reviewed-by tag to this version too. Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
pon., 14 lut 2022 o 14:03 Jarkko Nikula <jarkko.nikula@linux.intel.com> napisał(a): > > Hi > > On 2/14/22 14:47, Yang Li wrote: > > Eliminate the following coccicheck warnings: > > ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon > > ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > > --- > > > > --Changes in v2: > > According to Jan's suggestion > > Fix the same problem in check_i2c_req_sts() function. > > > > drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > For future contributions: Technically this would be v3 rather than v2 > RESEND since you fixed the typo in commit log noted by Jan for v2. > > Please use RESEND only if you'll send exactly the same version for > instance if you didn't receive any comments for several weeks or some > recipient was missing from Cc field. > > I believe Jan will give Reviewed-by tag to this version too. > > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Correct. Reviewed-by: Jan Dabros <jsd@semihalf.com> Best Regards, Jan
diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c index 752e0024db03..9d37becbd846 100644 --- a/drivers/i2c/busses/i2c-designware-amdpsp.c +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c @@ -172,7 +172,7 @@ static int check_i2c_req_sts(struct psp_i2c_req *req) case PSP_I2C_REQ_STS_INV_PARAM: default: return -EIO; - }; + } } static int psp_send_check_i2c_req(struct psp_i2c_req *req) @@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void) if (psp_i2c_access_count) { psp_i2c_access_count++; goto cleanup; - }; + } status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE); if (status) {
Eliminate the following coccicheck warnings: ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- --Changes in v2: According to Jan's suggestion Fix the same problem in check_i2c_req_sts() function. drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)