| Message ID | 20220214010348.129251-1-yang.lee@linux.alibaba.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next] i2c: designware: remove unneeded semicolon | expand |
pon., 14 lut 2022 o 02:03 Yang Li <yang.lee@linux.alibaba.com> napisał(a): > > Eliminate the following coccicheck warning: > ./drivers/i2c/busses/i2c-designware-amdpsp.c:248:2-3: Unneeded semicolon > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/i2c/busses/i2c-designware-amdpsp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c > index 752e0024db03..f589d3a1a19e 100644 > --- a/drivers/i2c/busses/i2c-designware-amdpsp.c > +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c > @@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void) > if (psp_i2c_access_count) { > psp_i2c_access_count++; > goto cleanup; > - }; > + } Thanks. While fixing this, please do the same for the 'switch' in check_i2c_req_sts() function above. Isn't your tool reporting this? Best Regards, Jan
diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c index 752e0024db03..f589d3a1a19e 100644 --- a/drivers/i2c/busses/i2c-designware-amdpsp.c +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c @@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void) if (psp_i2c_access_count) { psp_i2c_access_count++; goto cleanup; - }; + } status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE); if (status) {
Eliminate the following coccicheck warning: ./drivers/i2c/busses/i2c-designware-amdpsp.c:248:2-3: Unneeded semicolon Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/i2c/busses/i2c-designware-amdpsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)