| Message ID | 20190211103728.22959-1-wsa@the-dreams.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [RFC] i2c: ocores: turn incomplete kdoc into a comment | expand |
On Monday, February 11, 2019 11:37:28 AM CET Wolfram Sang wrote: > gcc complains, rightfully so, I think: > > drivers/i2c/busses/i2c-ocores.c:32: warning: Cannot understand * > @process_lock: protect I2C transfer process. on line 32 - I thought it was > a doc line > > Make it a simple comment. For me it's fine. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > --- > > Of course, if someone wants to provide a full kerneldoc, I am all for it. > > drivers/i2c/busses/i2c-ocores.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-ocores.c > b/drivers/i2c/busses/i2c-ocores.c index 738e6314b2be..8f9c86485dec 100644 > --- a/drivers/i2c/busses/i2c-ocores.c > +++ b/drivers/i2c/busses/i2c-ocores.c > @@ -28,9 +28,9 @@ > > #define OCORES_FLAG_POLL BIT(0) > > -/** > - * @process_lock: protect I2C transfer process. > - * ocores_process() and ocores_process_timeout() can't run in parallel. > +/* > + * 'process_lock' exists because ocores_process() and > ocores_process_timeout() + * can't run in parallel. > */ > struct ocores_i2c { > void __iomem *base;
On Mon, Feb 11, 2019 at 11:37:28AM +0100, Wolfram Sang wrote: > gcc complains, rightfully so, I think: > > drivers/i2c/busses/i2c-ocores.c:32: warning: Cannot understand * @process_lock: protect I2C transfer process. > on line 32 - I thought it was a doc line > > Make it a simple comment. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Peter, Andrew, good to go?
On Mon, Feb 11, 2019 at 11:37:28AM +0100, Wolfram Sang wrote: > gcc complains, rightfully so, I think: > > drivers/i2c/busses/i2c-ocores.c:32: warning: Cannot understand * @process_lock: protect I2C transfer process. > on line 32 - I thought it was a doc line > > Make it a simple comment. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Hi Wolfram Sorry, I lost track of this due to the revert. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Mon, Feb 11, 2019 at 11:37:28AM +0100, Wolfram Sang wrote: > gcc complains, rightfully so, I think: > > drivers/i2c/busses/i2c-ocores.c:32: warning: Cannot understand * @process_lock: protect I2C transfer process. > on line 32 - I thought it was a doc line > > Make it a simple comment. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Applied to for-next, thanks!
> Sorry, I lost track of this due to the revert.
No worries. Thanks for the tag.
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index 738e6314b2be..8f9c86485dec 100644 --- a/drivers/i2c/busses/i2c-ocores.c +++ b/drivers/i2c/busses/i2c-ocores.c @@ -28,9 +28,9 @@ #define OCORES_FLAG_POLL BIT(0) -/** - * @process_lock: protect I2C transfer process. - * ocores_process() and ocores_process_timeout() can't run in parallel. +/* + * 'process_lock' exists because ocores_process() and ocores_process_timeout() + * can't run in parallel. */ struct ocores_i2c { void __iomem *base;
gcc complains, rightfully so, I think: drivers/i2c/busses/i2c-ocores.c:32: warning: Cannot understand * @process_lock: protect I2C transfer process. on line 32 - I thought it was a doc line Make it a simple comment. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- Of course, if someone wants to provide a full kerneldoc, I am all for it. drivers/i2c/busses/i2c-ocores.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)