| Message ID | 20180520065035.7920-3-wsa@the-dreams.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | don't check number of I2C messages in drivers | expand |
On 2018-05-20 08:50, Wolfram Sang wrote: > Since commit 1eace8344c02 ("i2c: add param sanity check to > i2c_transfer()") and b7f625840267 ("i2c: add quirk checks to core"), the > I2C core does this check now. We can remove it here. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Reviewed-by: Peter Rosin <peda@axentia.se> > --- > > Only build tested. > > drivers/i2c/busses/i2c-opal.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-opal.c b/drivers/i2c/busses/i2c-opal.c > index 0aabb7eca0c5..dc2a23f4fb52 100644 > --- a/drivers/i2c/busses/i2c-opal.c > +++ b/drivers/i2c/busses/i2c-opal.c > @@ -94,8 +94,6 @@ static int i2c_opal_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, > */ > memset(&req, 0, sizeof(req)); > switch(num) { > - case 0: > - return 0; > case 1: > req.type = (msgs[0].flags & I2C_M_RD) ? > OPAL_I2C_RAW_READ : OPAL_I2C_RAW_WRITE; > @@ -114,8 +112,6 @@ static int i2c_opal_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, > req.size = cpu_to_be32(msgs[1].len); > req.buffer_ra = cpu_to_be64(__pa(msgs[1].buf)); > break; > - default: > - return -EOPNOTSUPP; > } > > rc = i2c_opal_send_request(opal_id, &req); >
On Sun, May 20, 2018 at 08:50:34AM +0200, Wolfram Sang wrote: > Since commit 1eace8344c02 ("i2c: add param sanity check to > i2c_transfer()") and b7f625840267 ("i2c: add quirk checks to core"), the > I2C core does this check now. We can remove it here. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Applied to for-next, thanks!
Wolfram Sang <wsa@the-dreams.de> writes: > Since commit 1eace8344c02 ("i2c: add param sanity check to > i2c_transfer()") and b7f625840267 ("i2c: add quirk checks to core"), the > I2C core does this check now. We can remove it here. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > --- > > Only build tested. It will get boot tested by me once it's in linux-next, which hopefully is sufficient for a patch like this. cheers > diff --git a/drivers/i2c/busses/i2c-opal.c b/drivers/i2c/busses/i2c-opal.c > index 0aabb7eca0c5..dc2a23f4fb52 100644 > --- a/drivers/i2c/busses/i2c-opal.c > +++ b/drivers/i2c/busses/i2c-opal.c > @@ -94,8 +94,6 @@ static int i2c_opal_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, > */ > memset(&req, 0, sizeof(req)); > switch(num) { > - case 0: > - return 0; > case 1: > req.type = (msgs[0].flags & I2C_M_RD) ? > OPAL_I2C_RAW_READ : OPAL_I2C_RAW_WRITE; > @@ -114,8 +112,6 @@ static int i2c_opal_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, > req.size = cpu_to_be32(msgs[1].len); > req.buffer_ra = cpu_to_be64(__pa(msgs[1].buf)); > break; > - default: > - return -EOPNOTSUPP; > } > > rc = i2c_opal_send_request(opal_id, &req); > -- > 2.11.0
diff --git a/drivers/i2c/busses/i2c-opal.c b/drivers/i2c/busses/i2c-opal.c index 0aabb7eca0c5..dc2a23f4fb52 100644 --- a/drivers/i2c/busses/i2c-opal.c +++ b/drivers/i2c/busses/i2c-opal.c @@ -94,8 +94,6 @@ static int i2c_opal_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, */ memset(&req, 0, sizeof(req)); switch(num) { - case 0: - return 0; case 1: req.type = (msgs[0].flags & I2C_M_RD) ? OPAL_I2C_RAW_READ : OPAL_I2C_RAW_WRITE; @@ -114,8 +112,6 @@ static int i2c_opal_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, req.size = cpu_to_be32(msgs[1].len); req.buffer_ra = cpu_to_be64(__pa(msgs[1].buf)); break; - default: - return -EOPNOTSUPP; } rc = i2c_opal_send_request(opal_id, &req);
Since commit 1eace8344c02 ("i2c: add param sanity check to i2c_transfer()") and b7f625840267 ("i2c: add quirk checks to core"), the I2C core does this check now. We can remove it here. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- Only build tested. drivers/i2c/busses/i2c-opal.c | 4 ---- 1 file changed, 4 deletions(-)