| Message ID | 20170609102937.3054567-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Headers | show |
Hi Arnd, On Fri, Jun 9, 2017 at 3:29 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The newly added support for the pcc mailbox fails to build > in some configurations: > > drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe': > drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration] > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function) > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in > > This includes the missing header file. > > Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/i2c/busses/i2c-xgene-slimpro.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c > index 8e5c8f28bc8b..7e89ba6fcf6f 100644 > --- a/drivers/i2c/busses/i2c-xgene-slimpro.c > +++ b/drivers/i2c/busses/i2c-xgene-slimpro.c > @@ -27,6 +27,7 @@ > #include <linux/dma-mapping.h> > #include <linux/i2c.h> > #include <linux/interrupt.h> > +#include <linux/io.h> > #include <linux/mailbox_client.h> > #include <linux/module.h> > #include <linux/of.h> > -- > 2.9.0 > Reviewed-by: Hoan Tran <hotran@apm.com> Thanks Hoan -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 09, 2017 at 12:29:12PM +0200, Arnd Bergmann wrote: > The newly added support for the pcc mailbox fails to build > in some configurations: > > drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe': > drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration] > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function) > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in > > This includes the missing header file. > > Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied to for-current, thanks!
On Thu, Jun 15, 2017 at 03:57:40PM +0200, Wolfram Sang wrote: > On Fri, Jun 09, 2017 at 12:29:12PM +0200, Arnd Bergmann wrote: > > The newly added support for the pcc mailbox fails to build > > in some configurations: > > > > drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe': > > drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration] > > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function) > > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in > > > > This includes the missing header file. > > > > Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Applied to for-current, thanks! Oops, the offending commit is only in for-next. So, reconsidered and moved this patch to for-next as well. Regards, Wolfram
diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c index 8e5c8f28bc8b..7e89ba6fcf6f 100644 --- a/drivers/i2c/busses/i2c-xgene-slimpro.c +++ b/drivers/i2c/busses/i2c-xgene-slimpro.c @@ -27,6 +27,7 @@ #include <linux/dma-mapping.h> #include <linux/i2c.h> #include <linux/interrupt.h> +#include <linux/io.h> #include <linux/mailbox_client.h> #include <linux/module.h> #include <linux/of.h>
The newly added support for the pcc mailbox fails to build in some configurations: drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe': drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration] drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function) drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in This includes the missing header file. Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/i2c/busses/i2c-xgene-slimpro.c | 1 + 1 file changed, 1 insertion(+)