| Message ID | 20170519204014.jumojwrdw6lfnycw@ninjato |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, May 19, 2017 at 1:40 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > > here is a regression fix for I2C that would be great to have in rc2 > already. Based on your tree from today. Please pull. Gaah. I hadn't tested this on my laptop, and instead of beign a regression fix, this looks like a new regression. My touchpad on the xps 13 9350 no longer works after this. Now, I'm not 100% certain it is this particular change, but I'm about half-way through the bisection, and this is the only thing that looks even remotely likely. And yes, the xps13 does use i2c_designware for the touchpad. I'll finish the bisection just top be sure, but the rest in there really looks like kvm stuff etc that shouldn't possibly affect the touchpad. So this commit will almost certainly be reverted unless somebody can figure out why it breaks. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Gaah. I hadn't tested this on my laptop, and instead of beign a > regression fix, this looks like a new regression. My touchpad on the > xps 13 9350 no longer works after this. Can you try e2c824924cdb41 ("i2c: designware: Fix bogus sda_hold_time due to uninitialized vars") from my for-current branch? I am waiting for buildbot results before I send out the pull request.
On Mon, May 22, 2017 at 1:14 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > > Can you try e2c824924cdb41 ("i2c: designware: Fix bogus sda_hold_time > due to uninitialized vars") from my for-current branch? I am waiting for > buildbot results before I send out the pull request. Have not tested that commit, but did verify that yes it was the i2c pull, and am about to reboot into a kernel that just zeroes those variables beforehand (which seems to be the same thing that commit does, although it also moves lines around for some unfathomable reason). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 22, 2017 at 1:28 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > Have not tested that commit, but did verify that yes it was the i2c > pull, and am about to reboot into a kernel that just zeroes those > variables beforehand (which seems to be the same thing that commit > does, although it also moves lines around for some unfathomable > reason). Confirmed. Initializing those fields to zero fixes it. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Confirmed. Initializing those fields to zero fixes it.
Thanks!
If you find the time, please push it out to master for testing purpose! (my touchpad is broken as well: 9d6408433019bfae15e2d0d5f4498c4ff70b86c0 - i2c: designware: don't infer timings described by ACPI from clock rate) Thanks, Tobias Klausmann On 5/22/17 11:04 PM, Wolfram Sang wrote: >> Confirmed. Initializing those fields to zero fixes it. > Thanks! > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Linus, here is a regression fix for I2C that would be great to have in rc2 already. Based on your tree from today. Please pull. Thanks, Wolfram The following changes since commit 8b4822de59d5d9919b9b045183a36c673ce20b73: Merge tag 'md/4.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md (2017-05-18 12:04:41 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current for you to fetch changes up to 9d6408433019bfae15e2d0d5f4498c4ff70b86c0: i2c: designware: don't infer timings described by ACPI from clock rate (2017-05-19 14:36:24 +0200) ---------------------------------------------------------------- Ard Biesheuvel (1): i2c: designware: don't infer timings described by ACPI from clock rate drivers/i2c/busses/i2c-designware-platdrv.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)