| Message ID | 1669025872-44226-1-git-send-email-wangyufen@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer | expand |
Hi Wang, On Mon, Nov 21, 2022 at 06:17:52PM +0800, Wang Yufen wrote: > Fix to return a negative error code from the gi2c->err instead of > 0. > > Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA") > Signed-off-by: Wang Yufen <wangyufen@huawei.com> > --- > drivers/i2c/busses/i2c-qcom-geni.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 84a7751..8fce98b 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -626,7 +626,6 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i > dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n", > gi2c->cur->flags, gi2c->cur->addr); > gi2c->err = -ETIMEDOUT; > - goto err; Looks good to me. Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasoluitons.com> Regards, Tommaso > } > > if (gi2c->err) { > -- > 1.8.3.1 >
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 84a7751..8fce98b 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -626,7 +626,6 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n", gi2c->cur->flags, gi2c->cur->addr); gi2c->err = -ETIMEDOUT; - goto err; } if (gi2c->err) {
Fix to return a negative error code from the gi2c->err instead of 0. Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA") Signed-off-by: Wang Yufen <wangyufen@huawei.com> --- drivers/i2c/busses/i2c-qcom-geni.c | 1 - 1 file changed, 1 deletion(-)