From patchwork Tue Feb 26 21:08:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?7Iah7J2A67SJ?= X-Patchwork-Id: 223398 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 287332C007C for ; Wed, 27 Feb 2013 08:09:07 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759964Ab3BZVIr (ORCPT ); Tue, 26 Feb 2013 16:08:47 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:10275 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752555Ab3BZVIp (ORCPT ); Tue, 26 Feb 2013 16:08:45 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIU00LD2IQJWDF0@mailout4.samsung.com> for linux-i2c@vger.kernel.org; Wed, 27 Feb 2013 06:08:43 +0900 (KST) Received: from epcpsbgx4.samsung.com ( [203.254.230.42]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 6A.09.25214.B542D215; Wed, 27 Feb 2013 06:08:43 +0900 (KST) X-AuditID: cbfee68e-b7fa46d00000627e-50-512d245b0499 Received: from epextmailer01 ( [203.254.219.151]) by epcpsbgx4.samsung.com (EPCPMTA) with SMTP id 83.B2.13994.B542D215; Wed, 27 Feb 2013 06:08:43 +0900 (KST) Date: Tue, 26 Feb 2013 21:08:43 +0000 (GMT) From: =?euc-kr?B?vNvAurrA?= Subject: I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8 To: "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" Reply-to: eunb.song@samsung.com MIME-version: 1.0 X-MTR: 20130226210722347@eunb.song Msgkey: 20130226210722347@eunb.song X-EPLocale: ko_KR.euc-kr X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20130226210722347@eunb.song X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N Content-transfer-encoding: base64 Content-type: text/plain; charset=euc-kr MIME-version: 1.0 Message-id: <16202598.147281361912922998.JavaMail.weblogic@epml02> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+Zlm60im6gwZcnmhYdf78wOjB6fN4k F8AYxWWTkpqTWZZapG+XwJVxaVc3Y8Eh7opXC5azNTDO4O5i5OQQElCRaPn/nRHElhAwkbgz 8xQThC0mceHeejaImmWMEqt6VWBqVq65w9zFyAUUn88o8WjRIVaQBIuAqsSypd9ZQGw2oKIN PyawdzFycAgLxEic3CYIEhYRqJFo/TaVEWKmvMTk05fZQWxeAUGJkzOfsEDMV5Jo/TWTBSKu LHHx8zaouITErOkXWCFsXokZ7U+h4nIS076uYYawpSXOz9rACHP/4u+PoeL8Esdu72ACOQek 98n9YJgxuzd/YYOwBSSmnjkI1aousax9M1Qrn8SahW9ZYMbsOrWcGab3/pa54KBiFlCUmNL9 kB3C1pL48mMfG7q3eAWcJBa++cAICjYJgakcEp2PXzBOYFSahaRuFpJZs5DMQlazgJFlFaNo akFyQXFSepGRXnFibnFpXrpecn7uJkZIWujbwXjzgPUhxmRglExklhJNzgemlbySeENjA2ND Q0tDM1NLUwPShJXEeeUvyQQKCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYFwkdcxt8n9jtjJ2 wxvKjy39/6W/adMs51BaMnXeCYNbbYXHi7/d5F7xV6Ti0YsdmaZnJ/fUHuQ3ePpaokE5a2ON +/sU31k5f6+ln9OprlqxbWfV48cvPNaUyWR4vXzl2D4rUp13/m2enj69mPeNDrw9cxlaj238 JMsXMUtm1bfFbLUzv1czH1NiKc5INNRiLipOBACOLjZnIQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKKsWRmVeSWpSXmKPExsVy+t/t6brRKrqBBtsPqVh0/P3C6MDo8XmT XABjVIZNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBQ JYWyxJxSoFBAYnGxkr6dTVF+aUmqQkZ+cYmtUrSRgbGekamJnpGxgZ6JQayVoYGBkSlQVUJG xqVd3YwFh7grXi1YztbAOIO7i5GTQ0hARaLl/3dGEFtCwERi5Zo7zBC2mMSFe+vZuhi5gGrm M0o8WnSIFSTBIqAqsWzpdxYQmw2oYcOPCexdjBwcwgIxEie3CYKERQRqJFq/TWWEmC8vMfn0 ZXYQm1dAUOLkzCcsEPOVJFp/zWSBiCtLXPy8DSouITFr+gVWCJtXYkb7U6i4nMS0r2ugbpOW OD9rAyPMnYu/P4aK80scu72DCeQckN4n94Nhxuze/IUNwhaQmHrmIFSrusSy9s1QrXwSaxa+ ZYEZs+vUcmaY3vtb5jKB2MwCihJTuh+yQ9haEl9+7GND9xavgJPEwjcfGCcwys5CkpqFpH0W knZkNQsYWVYxiqYWJBcUJ6VXmOgVJ+YWl+al6yXn525iBCeiZ0t2MDZcsD7EKMDBqMTDu+CS TqAQa2JZcWXuIUYJDmYlEd6PB4BCvCmJlVWpRfnxRaU5qcWHGJOBcTaRWUo0OR+YJPNK4g2N DYwNDS3NDUwNjSxIE1YS5z1kox4oJJCeWJKanZpakFoEs4WJg1OqgfHi9bXcN4snOersXGzQ LNjcJJf2rPx3WqGahdFuf6VIppVba+2OKe56nchxcH7dkV/ljYnV0wKn+yptWbZk3oRPp/Q8 /CN9okQeNfPGOXUldmhbFW1ZtnMPK/ftj3qzJqzeZ7C9al+pibNUzSb5Hd3O8na/T1W3X18q +TyX/3IXv/zyVdcMXiqxFGckGmoxFxUnAgCAnvcXiAMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org I've been debugging the abnormal operation of i2c on octeon. If a process is terminated by signal in the middle of i2c operation, next i2c read operation which is done by another process was failed. So i changed to ignore signal in the middle of i2c operation. After that the problem was not reproduced. Signed-off-by: EunBong Song diff -up drivers/i2c/busses/i2c-octeon.c{.orig,} --- drivers/i2c/busses/i2c-octeon.c.orig 2013-02-21 08:09:03.168018843 -0800 +++ drivers/i2c/busses/i2c-octeon.c 2013-02-21 08:09:38.344018898 -0800 @@ -183,7 +183,7 @@ static irqreturn_t octeon_i2c_isr(int ir struct octeon_i2c *i2c = dev_id; octeon_i2c_int_disable(i2c); - wake_up_interruptible(&i2c->queue); + wake_up(&i2c->queue); return IRQ_HANDLED; } @@ -206,7 +206,7 @@ static int octeon_i2c_wait(struct octeon octeon_i2c_int_enable(i2c); - result = wait_event_interruptible_timeout(i2c->queue, + result = wait_event_timeout(i2c->queue, octeon_i2c_test_iflg(i2c), i2c->adap.timeout);