From patchwork Wed Aug 23 14:42:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 805029 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="D3pti5Mj"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xcqs93gP4z9s78 for ; Thu, 24 Aug 2017 00:42:37 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932136AbdHWOmf (ORCPT ); Wed, 23 Aug 2017 10:42:35 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:38851 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754150AbdHWOm3 (ORCPT ); Wed, 23 Aug 2017 10:42:29 -0400 Received: by mail-lf0-f54.google.com with SMTP id y15so1336697lfd.5 for ; Wed, 23 Aug 2017 07:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OVyzB8N1P8QR0uR6qN7uOx0wtf9amaEOf3rrA1CA1zw=; b=D3pti5MjCzB25Uw4O9Du55Nck4nkOulWaFXDLmfaPXTfZj0A6TVUr10zmj6CL71p3K 3KM62TE2zpTJSmvVOjeJ9Q+P2vf6evsC6I16+Ea+GsQW6i4ena5Yfzlbb+LPlP+Un9nZ IiXwkawXlvXGYgroLOnTlcbJi5Jdo8aQxC7yg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OVyzB8N1P8QR0uR6qN7uOx0wtf9amaEOf3rrA1CA1zw=; b=OhpeBgHqER86R3VSNK6CnCeD4eaQqg+RsyE1BoDrrdWpi4sa8OdmBMNEmO+bTB7YM0 MjVRvcvGArvIf+N/FyVlg8sVAsz6zAj5TWHHBXUdOE8FE6E+kvU/+O0Y4QckbwiNn6qg 7BpMsldLxMO8k//l9Tnx4O7nVSQ5SyJVzDSfAYLQc/wUAk/ul78bute6NNUr4nCR2Oap TZ7/HSakLohZ/+/3KnyK/EHOyOZa9OihOWUGpXqjL+76MGc92MY7Z0Dc/3Yc4696f2UQ +EhBi7j+RPpoEIC8qLB+lAabajHyZzYsCUmWmyc9O1dVoIMSkNjJXyeZNMfEB0lo8lzS LX0Q== X-Gm-Message-State: AHYfb5iZJxaHaAfT2SzVwIa9dQ6tBGrDAC5jfRc04nglv4yFTesOm/3d AQ4nWaIIDLjqsasf X-Received: by 10.25.160.81 with SMTP id j78mr1143956lfe.192.1503499348358; Wed, 23 Aug 2017 07:42:28 -0700 (PDT) Received: from localhost.localdomain (h-158-174-22-67.NA.cust.bahnhof.se. [158.174.22.67]) by smtp.gmail.com with ESMTPSA id c89sm287593lfb.78.2017.08.23.07.42.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Aug 2017 07:42:27 -0700 (PDT) From: Ulf Hansson To: Wolfram Sang , "Rafael J . Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org Cc: Kevin Hilman , Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Jisheng Zhang , John Stultz , Guodong Xu , Sumit Semwal , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, Ulf Hansson Subject: [PATCH v2 8/9] i2c: designware: Don't resume device in the ->complete() callback Date: Wed, 23 Aug 2017 16:42:08 +0200 Message-Id: <1503499329-28834-9-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503499329-28834-1-git-send-email-ulf.hansson@linaro.org> References: <1503499329-28834-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org In case the PM core is able to use the direct_complete path during system sleep for the i2c device, the device is runtime resumed in the ->complete() callback. For ACPI platforms this is needed to synchronize the power state of the device, while for non-ACPI platforms this is a waste. To better deal with this, let's drop the ->complete() callback from the i2c-dw-plat driver altogether, thus avoiding the runtime resume of the device. This change still plays well for the ACPI case, because the ACPI PM domain's ->complete() callback, assigned to acpi_subsys_complete(), already deals with runtime resuming the device in case it's needed. Signed-off-by: Ulf Hansson --- Changes in v2: - New patch. --- drivers/i2c/busses/i2c-designware-platdrv.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 441afc7..fc6b99f 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -418,15 +418,8 @@ static int dw_i2c_plat_prepare(struct device *dev) { return pm_runtime_suspended(dev); } - -static void dw_i2c_plat_complete(struct device *dev) -{ - if (dev->power.direct_complete) - pm_request_resume(dev); -} #else #define dw_i2c_plat_prepare NULL -#define dw_i2c_plat_complete NULL #endif #ifdef CONFIG_PM @@ -462,7 +455,6 @@ static int dw_i2c_plat_suspend(struct device *dev) static const struct dev_pm_ops dw_i2c_dev_pm_ops = { .prepare = dw_i2c_plat_prepare, - .complete = dw_i2c_plat_complete, SET_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) SET_RUNTIME_PM_OPS(dw_i2c_plat_runtime_suspend, dw_i2c_plat_resume,