| Message ID | 1493628599-30552-7-git-send-email-preid@electromag.com.au |
|---|---|
| State | Superseded |
| Headers | show |
Hi, Just two notes about compatible. Looks fine otherwise. On Mon, May 01, 2017 at 04:49:56PM +0800, Phil Reid wrote: > From: Karl-Heinz Schneider <karl-heinz@schneider-inet.de> > > This patch adds device tree documentation for the sbs-manager > > Reviewed-by: Phil Reid <preid@electromag.com.au> > Signed-off-by: Karl-Heinz Schneider <karl-heinz@schneider-inet.de> > Signed-off-by: Phil Reid <preid@electromag.com.au> > --- > .../bindings/power/supply/sbs,sbs-manager.txt | 64 ++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt > new file mode 100644 > index 0000000..c523b37 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt > @@ -0,0 +1,64 @@ > +Binding for sbs-manager > + > +Required properties: > +- compatible: should be "lltc,ltc1760" or use "sbs,sbs-manager" as fallback. Use the same style as sbs-charger: Required properties: - compatible: "<vendor>,<part-number>", "sbs,sbs-manager" as fallback. The part number compatible string might be used in order to take care of vendor specific registers. > +- reg: integer, i2c address of the device. Should be <0xa>. > +Optional properties: > +- gpio-controller: Marks the port as GPIO controller. > + See "gpio-specifier" in .../devicetree/bindings/gpio/gpio.txt. > +- #gpio-cells: Should be <2>. The first cell is the pin number, the second cell > + is used to specify optional parameters: > + See "gpio-specifier" in .../devicetree/bindings/gpio/gpio.txt. > + > +From OS view the device is basically an i2c-mux used to communicate with up to > +four smart battery devices at address 0xb. The driver actually implements this > +behaviour. So standard i2c-mux nodes can be used to register up to four slave > +batteries. Channels will be numerated starting from 1 to 4. > + > +Example: > + > +batman@0a { > + compatible = "lltc,ltc1760"; This should be compatible = "lltc,ltc1760", "sbs,sbs-manager"; > + reg = <0x0a>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + i2c@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + battery@0b { > + compatible = "ti,bq2060", "sbs,sbs-battery"; > + reg = <0x0b>; > + sbs,battery-detect-gpios = <&batman 1 1>; > + }; > + }; > + > + i2c@2 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <2>; > + > + battery@0b { > + compatible = "ti,bq2060", "sbs,sbs-battery"; > + reg = <0x0b>; > + sbs,battery-detect-gpios = <&batman 2 1>; > + }; > + }; > + > + i2c@3 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <3>; > + > + battery@0b { > + compatible = "ti,bq2060", "sbs,sbs-battery"; > + reg = <0x0b>; > + sbs,battery-detect-gpios = <&batman 3 1>; > + }; > + }; > +}; -- Sebastian
diff --git a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt new file mode 100644 index 0000000..c523b37 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt @@ -0,0 +1,64 @@ +Binding for sbs-manager + +Required properties: +- compatible: should be "lltc,ltc1760" or use "sbs,sbs-manager" as fallback. +- reg: integer, i2c address of the device. Should be <0xa>. +Optional properties: +- gpio-controller: Marks the port as GPIO controller. + See "gpio-specifier" in .../devicetree/bindings/gpio/gpio.txt. +- #gpio-cells: Should be <2>. The first cell is the pin number, the second cell + is used to specify optional parameters: + See "gpio-specifier" in .../devicetree/bindings/gpio/gpio.txt. + +From OS view the device is basically an i2c-mux used to communicate with up to +four smart battery devices at address 0xb. The driver actually implements this +behaviour. So standard i2c-mux nodes can be used to register up to four slave +batteries. Channels will be numerated starting from 1 to 4. + +Example: + +batman@0a { + compatible = "lltc,ltc1760"; + reg = <0x0a>; + #address-cells = <1>; + #size-cells = <0>; + + gpio-controller; + #gpio-cells = <2>; + + i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + battery@0b { + compatible = "ti,bq2060", "sbs,sbs-battery"; + reg = <0x0b>; + sbs,battery-detect-gpios = <&batman 1 1>; + }; + }; + + i2c@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <2>; + + battery@0b { + compatible = "ti,bq2060", "sbs,sbs-battery"; + reg = <0x0b>; + sbs,battery-detect-gpios = <&batman 2 1>; + }; + }; + + i2c@3 { + #address-cells = <1>; + #size-cells = <0>; + reg = <3>; + + battery@0b { + compatible = "ti,bq2060", "sbs,sbs-battery"; + reg = <0x0b>; + sbs,battery-detect-gpios = <&batman 3 1>; + }; + }; +};