| Message ID | 1450898335-22814-1-git-send-email-akshay.bhat@timesys.com |
|---|---|
| State | Superseded |
| Headers | show |
On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote: > "at" is not a valid vendor prefix, correcting the same to "atmel" > I'm afraid you can't just do this change alone as it's used in some DTS. Though you may deprecated it along with update of current users. > Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com> > --- > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > index c50cf13..c4a01c0 100644 > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > @@ -20,11 +20,11 @@ adi,adt7476 +/-1C TDM Extended Temp Range I.C > adi,adt7490 +/-1C TDM Extended Temp Range I.C > adi,adxl345 Three-Axis Digital Accelerometer > adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too) > -at,24c08 i2c serial eeprom (24cxx) > atmel,24c00 i2c serial eeprom (24cxx) > atmel,24c01 i2c serial eeprom (24cxx) > atmel,24c02 i2c serial eeprom (24cxx) > atmel,24c04 i2c serial eeprom (24cxx) > +atmel,24c08 i2c serial eeprom (24cxx) > atmel,24c16 i2c serial eeprom (24cxx) > atmel,24c32 i2c serial eeprom (24cxx) > atmel,24c64 i2c serial eeprom (24cxx) > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote: > On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote: > > "at" is not a valid vendor prefix, correcting the same to "atmel" > > > > I'm afraid you can't just do this change alone as it's used in some > DTS. Though you may deprecated it along with update of current users. Well, in Linux, I2C core currently strips the vendor anyhow. This will probably be changed somewhen (tm), but for now, the impact for Linux should be extremly close to 0. > > > Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com> > > --- > > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > > index c50cf13..c4a01c0 100644 > > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt > > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > > @@ -20,11 +20,11 @@ adi,adt7476 +/-1C TDM Extended Temp Range I.C > > adi,adt7490 +/-1C TDM Extended Temp Range I.C > > adi,adxl345 Three-Axis Digital Accelerometer > > adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too) > > -at,24c08 i2c serial eeprom (24cxx) > > atmel,24c00 i2c serial eeprom (24cxx) > > atmel,24c01 i2c serial eeprom (24cxx) > > atmel,24c02 i2c serial eeprom (24cxx) > > atmel,24c04 i2c serial eeprom (24cxx) > > +atmel,24c08 i2c serial eeprom (24cxx) > > atmel,24c16 i2c serial eeprom (24cxx) > > atmel,24c32 i2c serial eeprom (24cxx) > > atmel,24c64 i2c serial eeprom (24cxx) > > -- > > 2.6.3 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > -- > With Best Regards, > Andy Shevchenko
On Sat, Jan 2, 2016 at 11:21 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote: >> On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote: >> > "at" is not a valid vendor prefix, correcting the same to "atmel" >> > >> >> I'm afraid you can't just do this change alone as it's used in some >> DTS. Though you may deprecated it along with update of current users. > > Well, in Linux, I2C core currently strips the vendor anyhow. This will > probably be changed somewhen (tm), but for now, the impact for Linux > should be extremly close to 0. Okay, no objections to the original patch then. > > >> >> > Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com> >> > --- >> > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt >> > index c50cf13..c4a01c0 100644 >> > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt >> > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt >> > @@ -20,11 +20,11 @@ adi,adt7476 +/-1C TDM Extended Temp Range I.C >> > adi,adt7490 +/-1C TDM Extended Temp Range I.C >> > adi,adxl345 Three-Axis Digital Accelerometer >> > adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too) >> > -at,24c08 i2c serial eeprom (24cxx) >> > atmel,24c00 i2c serial eeprom (24cxx) >> > atmel,24c01 i2c serial eeprom (24cxx) >> > atmel,24c02 i2c serial eeprom (24cxx) >> > atmel,24c04 i2c serial eeprom (24cxx) >> > +atmel,24c08 i2c serial eeprom (24cxx) >> > atmel,24c16 i2c serial eeprom (24cxx) >> > atmel,24c32 i2c serial eeprom (24cxx) >> > atmel,24c64 i2c serial eeprom (24cxx) >> > -- >> > 2.6.3 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> > the body of a message to majordomo@vger.kernel.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html >> > Please read the FAQ at http://www.tux.org/lkml/ >> >> >> >> -- >> With Best Regards, >> Andy Shevchenko
On Mon, Jan 04, 2016 at 08:22:33PM +0200, Andy Shevchenko wrote: > On Sat, Jan 2, 2016 at 11:21 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > > On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote: > >> On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote: > >> > "at" is not a valid vendor prefix, correcting the same to "atmel" > >> > > >> > >> I'm afraid you can't just do this change alone as it's used in some > >> DTS. Though you may deprecated it along with update of current users. > > > > Well, in Linux, I2C core currently strips the vendor anyhow. This will > > probably be changed somewhen (tm), but for now, the impact for Linux > > should be extremly close to 0. > > Okay, no objections to the original patch then. Heh, I just go reminded that eeproms already have a seperate binding description (Documentation/devicetree/bindings/eeprom/eeprom.txt). I will update the eeprom bindings and remove the entries from trivial devices.
diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt index c50cf13..c4a01c0 100644 --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt @@ -20,11 +20,11 @@ adi,adt7476 +/-1C TDM Extended Temp Range I.C adi,adt7490 +/-1C TDM Extended Temp Range I.C adi,adxl345 Three-Axis Digital Accelerometer adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too) -at,24c08 i2c serial eeprom (24cxx) atmel,24c00 i2c serial eeprom (24cxx) atmel,24c01 i2c serial eeprom (24cxx) atmel,24c02 i2c serial eeprom (24cxx) atmel,24c04 i2c serial eeprom (24cxx) +atmel,24c08 i2c serial eeprom (24cxx) atmel,24c16 i2c serial eeprom (24cxx) atmel,24c32 i2c serial eeprom (24cxx) atmel,24c64 i2c serial eeprom (24cxx)
"at" is not a valid vendor prefix, correcting the same to "atmel" Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com> --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)