Message ID | 1448360579-79260-13-git-send-email-andriy.shevchenko@linux.intel.com |
---|---|
State | Superseded |
Headers | show |
Hi Mika, [auto build test ERROR on v4.4-rc2] [also build test ERROR on next-20151124] [cannot apply to ljones-mfd/for-mfd-next] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/device-property-always-check-for-fwnode-type/20151124-183221 config: x86_64-randconfig-x019-11241713 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): drivers/mfd/intel-lpss-pci.c:68:30: error: array type has incomplete element type 'struct property_entry' static struct property_entry spt_i2c_properties[] = { ^ drivers/mfd/intel-lpss-pci.c:69:2: error: implicit declaration of function 'PROPERTY_ENTRY_U32' [-Werror=implicit-function-declaration] PROPERTY_ENTRY_U32("i2c-sda-hold-time-ns", 230), ^ >> drivers/mfd/intel-lpss-pci.c:73:15: error: variable 'spt_i2c_pset' has initializer but incomplete type static struct property_set spt_i2c_pset = { ^ drivers/mfd/intel-lpss-pci.c:74:2: error: unknown field 'properties' specified in initializer .properties = spt_i2c_properties, ^ drivers/mfd/intel-lpss-pci.c:74:16: warning: excess elements in struct initializer .properties = spt_i2c_properties, ^ drivers/mfd/intel-lpss-pci.c:74:16: note: (near initialization for 'spt_i2c_pset') drivers/mfd/intel-lpss-pci.c:82:30: error: array type has incomplete element type 'struct property_entry' static struct property_entry uart_properties[] = { ^ drivers/mfd/intel-lpss-pci.c:85:2: error: implicit declaration of function 'PROPERTY_ENTRY_U8' [-Werror=implicit-function-declaration] PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1), ^ drivers/mfd/intel-lpss-pci.c:89:15: error: variable 'uart_pset' has initializer but incomplete type static struct property_set uart_pset = { ^ drivers/mfd/intel-lpss-pci.c:90:2: error: unknown field 'properties' specified in initializer .properties = uart_properties, ^ drivers/mfd/intel-lpss-pci.c:90:16: warning: excess elements in struct initializer .properties = uart_properties, ^ drivers/mfd/intel-lpss-pci.c:90:16: note: (near initialization for 'uart_pset') >> drivers/mfd/intel-lpss-pci.c:68:30: warning: 'spt_i2c_properties' defined but not used [-Wunused-variable] static struct property_entry spt_i2c_properties[] = { ^ drivers/mfd/intel-lpss-pci.c:82:30: warning: 'uart_properties' defined but not used [-Wunused-variable] static struct property_entry uart_properties[] = { ^ cc1: some warnings being treated as errors vim +/spt_i2c_pset +73 drivers/mfd/intel-lpss-pci.c 62 static INTEL_LPSS_PM_OPS(intel_lpss_pci_pm_ops); 63 64 static const struct intel_lpss_platform_info spt_info = { 65 .clk_rate = 120000000, 66 }; 67 > 68 static struct property_entry spt_i2c_properties[] = { 69 PROPERTY_ENTRY_U32("i2c-sda-hold-time-ns", 230), 70 { }, 71 }; 72 > 73 static struct property_set spt_i2c_pset = { 74 .properties = spt_i2c_properties, 75 }; 76 77 static const struct intel_lpss_platform_info spt_i2c_info = { 78 .clk_rate = 120000000, 79 .pset = &spt_i2c_pset, 80 }; 81 82 static struct property_entry uart_properties[] = { 83 PROPERTY_ENTRY_U32("reg-io-width", 4), 84 PROPERTY_ENTRY_U32("reg-shift", 2), 85 PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1), 86 { }, 87 }; 88 89 static struct property_set uart_pset = { > 90 .properties = uart_properties, 91 }; 92 93 static const struct intel_lpss_platform_info spt_uart_info = { --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index b6fd904..6c5bbda 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -25,6 +25,20 @@ static const struct intel_lpss_platform_info spt_info = { .clk_rate = 120000000, }; +static struct property_entry spt_i2c_properties[] = { + PROPERTY_ENTRY_U32("i2c-sda-hold-time-ns", 230), + { }, +}; + +static struct property_set spt_i2c_pset = { + .properties = spt_i2c_properties, +}; + +static const struct intel_lpss_platform_info spt_i2c_info = { + .clk_rate = 120000000, + .pset = &spt_i2c_pset, +}; + static const struct intel_lpss_platform_info bxt_info = { .clk_rate = 100000000, }; @@ -35,8 +49,8 @@ static const struct intel_lpss_platform_info bxt_i2c_info = { static const struct acpi_device_id intel_lpss_acpi_ids[] = { /* SPT */ - { "INT3446", (kernel_ulong_t)&spt_info }, - { "INT3447", (kernel_ulong_t)&spt_info }, + { "INT3446", (kernel_ulong_t)&spt_i2c_info }, + { "INT3447", (kernel_ulong_t)&spt_i2c_info }, /* BXT */ { "80860AAC", (kernel_ulong_t)&bxt_i2c_info }, { "80860ABC", (kernel_ulong_t)&bxt_info }, diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c index 74f0d6d..3c84ceb 100644 --- a/drivers/mfd/intel-lpss-pci.c +++ b/drivers/mfd/intel-lpss-pci.c @@ -65,6 +65,20 @@ static const struct intel_lpss_platform_info spt_info = { .clk_rate = 120000000, }; +static struct property_entry spt_i2c_properties[] = { + PROPERTY_ENTRY_U32("i2c-sda-hold-time-ns", 230), + { }, +}; + +static struct property_set spt_i2c_pset = { + .properties = spt_i2c_properties, +}; + +static const struct intel_lpss_platform_info spt_i2c_info = { + .clk_rate = 120000000, + .pset = &spt_i2c_pset, +}; + static struct property_entry uart_properties[] = { PROPERTY_ENTRY_U32("reg-io-width", 4), PROPERTY_ENTRY_U32("reg-shift", 2), @@ -134,20 +148,20 @@ static const struct pci_device_id intel_lpss_pci_ids[] = { { PCI_VDEVICE(INTEL, 0x9d28), (kernel_ulong_t)&spt_uart_info }, { PCI_VDEVICE(INTEL, 0x9d29), (kernel_ulong_t)&spt_info }, { PCI_VDEVICE(INTEL, 0x9d2a), (kernel_ulong_t)&spt_info }, - { PCI_VDEVICE(INTEL, 0x9d60), (kernel_ulong_t)&spt_info }, - { PCI_VDEVICE(INTEL, 0x9d61), (kernel_ulong_t)&spt_info }, - { PCI_VDEVICE(INTEL, 0x9d62), (kernel_ulong_t)&spt_info }, - { PCI_VDEVICE(INTEL, 0x9d63), (kernel_ulong_t)&spt_info }, - { PCI_VDEVICE(INTEL, 0x9d64), (kernel_ulong_t)&spt_info }, - { PCI_VDEVICE(INTEL, 0x9d65), (kernel_ulong_t)&spt_info }, + { PCI_VDEVICE(INTEL, 0x9d60), (kernel_ulong_t)&spt_i2c_info }, + { PCI_VDEVICE(INTEL, 0x9d61), (kernel_ulong_t)&spt_i2c_info }, + { PCI_VDEVICE(INTEL, 0x9d62), (kernel_ulong_t)&spt_i2c_info }, + { PCI_VDEVICE(INTEL, 0x9d63), (kernel_ulong_t)&spt_i2c_info }, + { PCI_VDEVICE(INTEL, 0x9d64), (kernel_ulong_t)&spt_i2c_info }, + { PCI_VDEVICE(INTEL, 0x9d65), (kernel_ulong_t)&spt_i2c_info }, { PCI_VDEVICE(INTEL, 0x9d66), (kernel_ulong_t)&spt_uart_info }, /* SPT-H */ { PCI_VDEVICE(INTEL, 0xa127), (kernel_ulong_t)&spt_uart_info }, { PCI_VDEVICE(INTEL, 0xa128), (kernel_ulong_t)&spt_uart_info }, { PCI_VDEVICE(INTEL, 0xa129), (kernel_ulong_t)&spt_info }, { PCI_VDEVICE(INTEL, 0xa12a), (kernel_ulong_t)&spt_info }, - { PCI_VDEVICE(INTEL, 0xa160), (kernel_ulong_t)&spt_info }, - { PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_info }, + { PCI_VDEVICE(INTEL, 0xa160), (kernel_ulong_t)&spt_i2c_info }, + { PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info }, { PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info }, { } };