From patchwork Tue Mar 26 06:56:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 231101 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 90EBC2C00C0 for ; Tue, 26 Mar 2013 17:56:59 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757455Ab3CZG46 (ORCPT ); Tue, 26 Mar 2013 02:56:58 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:31514 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755131Ab3CZG46 (ORCPT ); Tue, 26 Mar 2013 02:56:58 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MK900HOV9YXBVG0@mailout1.samsung.com> for linux-i2c@vger.kernel.org; Tue, 26 Mar 2013 15:56:57 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 88.FC.07735.9B641515; Tue, 26 Mar 2013 15:56:57 +0900 (KST) X-AuditID: cbfee68e-b7f946d000001e37-b5-515146b962f4 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id DC.B6.13494.8B641515; Tue, 26 Mar 2013 15:56:57 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MK90030V9YWDOA0@mmp1.samsung.com>; Tue, 26 Mar 2013 15:56:56 +0900 (KST) From: Jingoo Han To: 'Wolfram Sang' Cc: 'Wolfram Sang' , linux-i2c@vger.kernel.org, 'Ben Dooks' , 'Jingoo Han' References: <001501ce29ee$fd997150$f8cc53f0$%han@samsung.com> In-reply-to: <001501ce29ee$fd997150$f8cc53f0$%han@samsung.com> Subject: [PATCH 3/5] i2c: puv3: add CONFIG_PM_SLEEP to suspend function Date: Tue, 26 Mar 2013 15:56:56 +0900 Message-id: <001701ce29ef$1af32cf0$50d986d0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4p7v1ycpyzyU1RSmSlP3LAxFmscgAABEyw Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t8zI92dboGBBvdnsFlMWneAyeLywkus Fh1/vzBa9GyfyWax8sQsZgdWj7+rXjB79G1Zxehx8tQTFo/Pm+QCWKK4bFJSczLLUov07RK4 Ml7t289csI67YlujRwPjKs4uRk4OCQETiV/zprFC2GISF+6tZ+ti5OIQEljGKNF4aTsTTNGq 9btZIRKLGCUWdK8A6xAS+MUosXGqOIjNJqAm8eXLYXYQWwTIfvbxKyNIA7NAH6PE4/btLBAN thJdN9+xgdicAnYSf5f9BGsQFnCX6J/yE6yGRUBVon/XebDNvED1Ow63MULYghI/Jt8Dq2EW 0JJYv/M4E4QtL7F5zVvmLkYOoEvVJR791YW4wUji58yNzBAlIhL7XrwDu0dC4BK7xPmuJWwQ uwQkvk0+xALRKyux6QAzxMOSEgdX3GCZwCgxC8nmWUg2z0KyeRaSFQsYWVYxiqYWJBcUJ6UX GekVJ+YWl+al6yXn525ihMRn3w7GmwesDzEmA62fyCwlmpwPjO+8knhDYzMjC1MTU2Mjc0sz 0oSVxHnVWqwDhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTB2FT+5OHXWqUklO48Ha3yKfbFo r9/eqHWLr5yOYPoe/eRIofbW7zJpXvd9Z3oZ/p+3f7NBF6OcYjN7nMwxvjLH3QpfOew5Fnex SU96N4W/9zIb32ezVfrH49gvXZ9fJySlkuU10/GnTeCPVxtj6vnXJPHEz2HwU7dnPinkvfN2 3JrSA11TvVKVWIozEg21mIuKEwGIKtU45QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPKsWRmVeSWpSXmKPExsVy+t9jAd2dboGBBo8mMFlMWneAyeLywkus Fh1/vzBa9GyfyWax8sQsZgdWj7+rXjB79G1Zxehx8tQTFo/Pm+QCWKIaGG0yUhNTUosUUvOS 81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgBYrKZQl5pQChQISi4uV9O0w TQgNcdO1gGmM0PUNCYLrMTJAAwnrGDNe7dvPXLCOu2Jbo0cD4yrOLkZODgkBE4lV63ezQthi EhfurWfrYuTiEBJYxCixoHsFWEJI4BejxMap4iA2m4CaxJcvh9lBbBEg+9nHr4wgDcwCfYwS j9u3s0A02Ep03XzHBmJzCthJ/F32E6xBWMBdon/KT7AaFgFVif5d55lAbF6g+h2H2xghbEGJ H5PvgdUwC2hJrN95nAnClpfYvOYtcxcjB9Cl6hKP/upC3GAk8XPmRmaIEhGJfS/eMU5gFJqF ZNIsJJNmIZk0C0nLAkaWVYyiqQXJBcVJ6blGesWJucWleel6yfm5mxjB0f9MegfjqgaLQ4wC HIxKPLwcYQGBQqyJZcWVuYcYJTiYlUR4/zgGBgrxpiRWVqUW5ccXleakFh9iTAZ6dCKzlGhy PjAx5ZXEGxqbmBlZGplZGJmYm5MmrCTOe7DVOlBIID2xJDU7NbUgtQhmCxMHp1QDY1n8b9H9 kU5bsn4veRhm/EfEO23Ws+jrxnFfQz0Dr73UXf/hluvElN99muctzhk622fUREUsOP1OjPul qWzDCW83tW+3pgn86DkXluj+JFjW6ofY3HXFl7sOrVR5NU3p6D7bvf+CDMpijRZ33Z5i2v6Y 0yV5wsf8a+d+Xr7jwfh7t9C7tKi9v5RYijMSDbWYi4oTAf8K+0JCAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Add CONFIG_PM_SLEEP to suspend function to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled. drivers/i2c/busses/i2c-puv3.c:255:12: warning: 'puv3_i2c_suspend' defined but not used [-Wunused-function] Signed-off-by: Jingoo Han --- drivers/i2c/busses/i2c-puv3.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-puv3.c b/drivers/i2c/busses/i2c-puv3.c index 8acef65..1a73ce0 100644 --- a/drivers/i2c/busses/i2c-puv3.c +++ b/drivers/i2c/busses/i2c-puv3.c @@ -251,7 +251,7 @@ static int puv3_i2c_remove(struct platform_device *pdev) return rc; } -#ifdef CONFIG_PM +#ifdef CONFIG_PM_SLEEP static int puv3_i2c_suspend(struct device *dev) { int poll_count; @@ -264,13 +264,9 @@ static int puv3_i2c_suspend(struct device *dev) return 0; } +#endif static SIMPLE_DEV_PM_OPS(puv3_i2c_pm, puv3_i2c_suspend, NULL); -#define PUV3_I2C_PM (&puv3_i2c_pm) - -#else -#define PUV3_I2C_PM NULL -#endif static struct platform_driver puv3_i2c_driver = { .probe = puv3_i2c_probe, @@ -278,7 +274,7 @@ static struct platform_driver puv3_i2c_driver = { .driver = { .name = "PKUnity-v3-I2C", .owner = THIS_MODULE, - .pm = PUV3_I2C_PM, + .pm = &puv3_i2c_pm, } };