| Message ID | cover.1765279318.git.u.kleine-koenig@baylibre.com |
|---|---|
| Headers | show |
| Series | fsi: Convert to bus probe mechanism | expand |
Hello Eddie, On Tue, Dec 09, 2025 at 12:39:28PM +0100, Uwe Kleine-König wrote: > Hello, > > this is the 2nd installment of the series converting the fsi bus to use > bus methods for .probe and .remove. The changes since the first > iteration---that can be found at > https://lore.kernel.org/lkml/cover.1764434226.git.ukleinek@kernel.org/ > --- are: > > - (trivially) rebase to v6.18 > - add tags by Andi (for the i2c parts) and Mark Brown (for the spi > parts) > - Add a patch converting drivers/fsi/i2cr-scom.c (#8) > > In the earlier thread I thought I made a mistake for (implicit) v1, but > I confused fsi with fsl and the problem doesn't apply here as it doesn't > touch the shutdown callback. > > This series is not urgent, but it would be great to get this into > v6.19-rc1. With Mark's Acks and Andi's tags (though they are not an > Ack) this should be fine to be picked up in one go by Eddie. > > As before there are two commit refs that should refer to the commit for > patch #2 ("fsi: Assign driver's bus in fsi_driver_register()"). As I > cannot know the commit hash yet, I wrote "FIXME" and these need updating > when the series is picked up. gentle ping. While my quest to drop .probe() and .remove() is still in early stages, I'd like to see this series go in before it bitrots. It should have all the acks necessary to merge it. Alternatively, should I ask Greg (added to Cc:) to merge? Best regards Uwe
On 1/12/26 3:47 AM, Uwe Kleine-König wrote: > Hello Eddie, > > On Tue, Dec 09, 2025 at 12:39:28PM +0100, Uwe Kleine-König wrote: >> Hello, >> >> this is the 2nd installment of the series converting the fsi bus to use >> bus methods for .probe and .remove. The changes since the first >> iteration---that can be found at >> https://lore.kernel.org/lkml/cover.1764434226.git.ukleinek@kernel.org/ >> --- are: >> >> - (trivially) rebase to v6.18 >> - add tags by Andi (for the i2c parts) and Mark Brown (for the spi >> parts) >> - Add a patch converting drivers/fsi/i2cr-scom.c (#8) >> >> In the earlier thread I thought I made a mistake for (implicit) v1, but >> I confused fsi with fsl and the problem doesn't apply here as it doesn't >> touch the shutdown callback. >> >> This series is not urgent, but it would be great to get this into >> v6.19-rc1. With Mark's Acks and Andi's tags (though they are not an >> Ack) this should be fine to be picked up in one go by Eddie. >> >> As before there are two commit refs that should refer to the commit for >> patch #2 ("fsi: Assign driver's bus in fsi_driver_register()"). As I >> cannot know the commit hash yet, I wrote "FIXME" and these need updating >> when the series is picked up. > gentle ping. While my quest to drop .probe() and .remove() is still in > early stages, I'd like to see this series go in before it bitrots. It > should have all the acks necessary to merge it. So sorry for the delay. Thank you very much for the series! Greg, please merge at your earliest convenience. Thanks! Eddie > > Alternatively, should I ask Greg (added to Cc:) to merge? > > Best regards > Uwe
Hello, this is the 2nd installment of the series converting the fsi bus to use bus methods for .probe and .remove. The changes since the first iteration---that can be found at https://lore.kernel.org/lkml/cover.1764434226.git.ukleinek@kernel.org/ --- are: - (trivially) rebase to v6.18 - add tags by Andi (for the i2c parts) and Mark Brown (for the spi parts) - Add a patch converting drivers/fsi/i2cr-scom.c (#8) In the earlier thread I thought I made a mistake for (implicit) v1, but I confused fsi with fsl and the problem doesn't apply here as it doesn't touch the shutdown callback. This series is not urgent, but it would be great to get this into v6.19-rc1. With Mark's Acks and Andi's tags (though they are not an Ack) this should be fine to be picked up in one go by Eddie. As before there are two commit refs that should refer to the commit for patch #2 ("fsi: Assign driver's bus in fsi_driver_register()"). As I cannot know the commit hash yet, I wrote "FIXME" and these need updating when the series is picked up. Thanks Uwe Uwe Kleine-König (13): fsi: Make use of module_fsi_driver() fsi: Assign driver's bus in fsi_driver_register() fsi: Provide thin wrappers around dev_[gs]et_data() for fsi devices i2c: fsi: Drop assigning fsi bus spi: fsi: Drop assigning fsi bus fsi: Make fsi_bus_type a private variable to the core fsi: Create bus specific probe and remove functions fsi: i2cr-scom: Convert to fsi bus probe mechanism fsi: master: Convert to fsi bus probe mechanism fsi: sbefifo: Convert to fsi bus probe mechanism fsi: scom: Convert to fsi bus probe mechanism i2c: fsi: Convert to fsi bus probe mechanism spi: fsi: Convert to fsi bus probe mechanism drivers/fsi/fsi-core.c | 107 ++++++++++++++++++++++++++--------- drivers/fsi/fsi-master-hub.c | 17 +++--- drivers/fsi/fsi-sbefifo.c | 31 +++------- drivers/fsi/fsi-scom.c | 30 +++------- drivers/fsi/i2cr-scom.c | 15 ++--- drivers/i2c/busses/i2c-fsi.c | 16 +++--- drivers/spi/spi-fsi.c | 7 +-- include/linux/fsi.h | 13 ++++- 8 files changed, 131 insertions(+), 105 deletions(-) base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449