mbox series

[uL,RFC,v3,0/8] OMAP I2C driver cleanups

Message ID 20260930223503.616776-1-afd@ti.com
Headers show
Series OMAP I2C driver cleanups | expand

Message

Andrew Davis Sept. 30, 2026, 10:34 p.m. UTC
Hello all,

Some hopefully simple cleanups and updates found while using this driver
as reference when porting the same over to Zephyr. No functional changes.

Thanks,
Andrew

Changes for v3:
 - Fix OMAP_I2C_STAT_REG value in [1/8] (Sashiko)
 - Add Acked-by tag

Changes for v2:
 - Seems bitfield.h is not indirectly included for all archs, include
   it explicitly in patch [8/8]
 - Add Reviewed-by tags

Andrew Davis (8):
  i2c: omap: Drop bit shift for I2C register addresses
  i2c: omap: Remove unused is_rdr and is_xdr variables
  i2c: omap: Use devm_pm_runtime_enable() helper
  i2c: omap: Combine event flags register definitions
  i2c: omap: Use bool for flag values
  i2c: omap: Make reset bit name match register name
  i2c: omap: Switch to using BIT and GENMASK
  i2c: omap: Add OMAP_I2C_BUF_{TX,RX}TRSH definitions

 arch/arm/mach-omap1/i2c.c              |   4 -
 drivers/i2c/busses/i2c-omap.c          | 255 +++++++++++--------------
 include/linux/platform_data/i2c-omap.h |   5 -
 3 files changed, 113 insertions(+), 151 deletions(-)

Comments

Andrew Davis Sept. 30, 2026, 10:37 p.m. UTC | #1
On 9/30/26 5:34 PM, Andrew Davis wrote:
> Hello all,
> 
> Some hopefully simple cleanups and updates found while using this driver
> as reference when porting the same over to Zephyr. No functional changes.
> 
> Thanks,
> Andrew
> 

Just noticed this was sent with the wrong tag, not an RFC, let me
know if this needs resent with just [PATCH v3] or if your tooling
can handle it the same.

Andrew

> Changes for v3:
>   - Fix OMAP_I2C_STAT_REG value in [1/8] (Sashiko)
>   - Add Acked-by tag
> 
> Changes for v2:
>   - Seems bitfield.h is not indirectly included for all archs, include
>     it explicitly in patch [8/8]
>   - Add Reviewed-by tags
> 
> Andrew Davis (8):
>    i2c: omap: Drop bit shift for I2C register addresses
>    i2c: omap: Remove unused is_rdr and is_xdr variables
>    i2c: omap: Use devm_pm_runtime_enable() helper
>    i2c: omap: Combine event flags register definitions
>    i2c: omap: Use bool for flag values
>    i2c: omap: Make reset bit name match register name
>    i2c: omap: Switch to using BIT and GENMASK
>    i2c: omap: Add OMAP_I2C_BUF_{TX,RX}TRSH definitions
> 
>   arch/arm/mach-omap1/i2c.c              |   4 -
>   drivers/i2c/busses/i2c-omap.c          | 255 +++++++++++--------------
>   include/linux/platform_data/i2c-omap.h |   5 -
>   3 files changed, 113 insertions(+), 151 deletions(-)
>