From patchwork Fri Mar 24 20:11:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 743367 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vqZMB2693z9s1h for ; Sat, 25 Mar 2017 07:11:50 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="llTaSlxf"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967405AbdCXULm (ORCPT ); Fri, 24 Mar 2017 16:11:42 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35439 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967365AbdCXULf (ORCPT ); Fri, 24 Mar 2017 16:11:35 -0400 Received: by mail-pf0-f179.google.com with SMTP id 20so289650pfk.2 for ; Fri, 24 Mar 2017 13:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6NYIYTJxfK6sxk0Jrz3Jd87wCRPBxKyFbj7aFttzbX8=; b=llTaSlxfZR1WnFks67e8tVzCaRoufKcwwLdx+FHll2mmQQHDluEKrdvGq/5Ojav594 UZGDK3/KSvUwwqUSYgE403dEMspkcm8FGbUyXjM4la24yNWTQVItqDV9E4D+4tzuztSr axNWGGiMOrD5OqD+dG3+nPd93aNlBP+AHD4FX40EbfjpCpnjBJ2kQq80tw7eXjfpYkJ3 6E+IhMxtiLVBIqKXimAaINa8yfYYeWTUXvErnez5llMm7et0y8XgHSTC+iuT2s279on6 fLmg7vyTv7RAt1Q9AxEI1hI7IRuvtU7l6yT+DpbspbSsICs9KD9IKm28kZyHck6Vuz8S QYbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=6NYIYTJxfK6sxk0Jrz3Jd87wCRPBxKyFbj7aFttzbX8=; b=Y6pVzfJwv4WAunki5168heNpDsBA563UYZuTV0y8u9L7HfD5zeUhWIcVvXI/uleU2L 9s/uH6SiwVxWU3Pmp4+oQPGBk3cXIyzbv1A7cPrhtXsUjx3SLisSeMC6+03xhV6Z4uMk MSx19T18KAVzjYbV6eDVqpn96fvUIZ57IuBcLPPzs98nIMVu0EUE3pnbD/WOkugFLjZR U5X6NLdF81rp6ztAgLjoinzByaCchWCb54QfLskOVlw7I23CZrQvyhbUWilgGEcCSqhG tud3KcsJk2B30zinU5PoKdns0r43gjuN1TpPb/vU6ZHh4v1l4SRKr8xWCiG4POImQfQ1 WQOQ== X-Gm-Message-State: AFeK/H1sG54/Okgtb9ds7BLwLM1GMaYdmYRMxoaRcJhKcufovD99aS7WFIMmd7/ZwJbvu7hk X-Received: by 10.84.176.100 with SMTP id u91mr13462734plb.112.1490386294182; Fri, 24 Mar 2017 13:11:34 -0700 (PDT) Received: from localhost (c-98-203-232-209.hsd1.wa.comcast.net. [98.203.232.209]) by smtp.gmail.com with ESMTPSA id p9sm6286336pfe.22.2017.03.24.13.11.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Mar 2017 13:11:33 -0700 (PDT) From: Kevin Hilman To: Neil Armstrong Cc: carlo@caione.org, linus.walleij@linaro.org, linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFT PATCH 0/6] pinctrl: meson: Fix gpio-ranged for GPIO Hog Organization: BayLibre References: <1490286449-19448-1-git-send-email-narmstrong@baylibre.com> Date: Fri, 24 Mar 2017 13:11:32 -0700 In-Reply-To: <1490286449-19448-1-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Thu, 23 Mar 2017 17:27:23 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Neil Armstrong writes: > Whem trying to add a gpio hog to enable the USB Hub on the Odroid-C2, I > encountered a strange bug where when calling gpiochip_add_data() the gpiolib > code was trying to add the Hog but failed because the gpio ranges were missing. > > In the meson-pinctrl driver, the gpio ranges are added manually /after/ the > call to gpiochip_add_data(). > The arch/arm meson8 and meson8b patches has not been tested, this is why this > patchset is an RFT. > > So this patchset uses the DT gpio-ranges attribute instead and solves the issue. > > The final patch is the actual GPIO Hog for the Odroid-C2 board, which is an ugly > hack but is necessary to have USB Ports working on the board until the generic > power sequence framework is merged. > > Neil Armstrong (6): > ARM64: dts: meson-gxbb: Add gpio-ranges properties > ARM64: dts: meson-gxl: Add gpio-ranges properties > ARM: dts: meson8: Add gpio-ranges properties > ARM: dts: meson8b: Add gpio-ranges properties > pinctrl: meson: use gpio-ranges from DT > ARM64: dts: meson-gxbb: Add USB Hub GPIO hog Not sure what kind of extra testing is needed on meson8*, but I tested on meson8b-odroidc1 by replacing the heartbeat LED GPIO with a GPIO hog[1] and see the LED turn on and stay on, so it seems good to me. Tested-by: Kevin Hilman Kevin [1] --- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index e50f1a1fdbc7..d750d6b4c9f1 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -60,6 +60,7 @@ reg = <0x40000000 0x40000000>; }; +/* leds { compatible = "gpio-leds"; blue { @@ -69,10 +70,18 @@ default-state = "off"; }; }; +*/ }; &uart_AO { status = "okay"; pinctrl-0 = <&uart_ao_a_pins>; pinctrl-names = "default"; + + usb-hub { + gpio-hog; + gpios = ; + output-high; + line-name = "usb-hub-reset"; + }; };