| Message ID | f56e271107221a2f41f256e2759a92cfe29624a8.1475489558.git-series.maxime.ripard@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Oct 3, 2016 at 6:21 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Since we have some bindings header for our hardcoded flags, let's use them > when we can. "Use macros from bindings header file for DT parsing" would make the subject clearer. Otherwise, Acked-by: Chen-Yu Tsai <wens@csie.org> > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c > index 64f7f6dcc027..5be455d5e252 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c > @@ -28,6 +28,8 @@ > #include <linux/platform_device.h> > #include <linux/slab.h> > > +#include <dt-bindings/pinctrl/sun4i-a10.h> > + > #include "../core.h" > #include "../../gpio/gpiolib.h" > #include "pinctrl-sunxi.h" > @@ -164,9 +166,9 @@ static int sunxi_pctrl_parse_bias_prop(struct device_node *node) > return -EINVAL; > > switch (val) { > - case 1: > + case SUN4I_PINCTRL_PULL_UP: > return PIN_CONFIG_BIAS_PULL_UP; > - case 2: > + case SUN4I_PINCTRL_PULL_DOWN: > return PIN_CONFIG_BIAS_PULL_DOWN; > } > > -- > git-series 0.8.10 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index 64f7f6dcc027..5be455d5e252 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -28,6 +28,8 @@ #include <linux/platform_device.h> #include <linux/slab.h> +#include <dt-bindings/pinctrl/sun4i-a10.h> + #include "../core.h" #include "../../gpio/gpiolib.h" #include "pinctrl-sunxi.h" @@ -164,9 +166,9 @@ static int sunxi_pctrl_parse_bias_prop(struct device_node *node) return -EINVAL; switch (val) { - case 1: + case SUN4I_PINCTRL_PULL_UP: return PIN_CONFIG_BIAS_PULL_UP; - case 2: + case SUN4I_PINCTRL_PULL_DOWN: return PIN_CONFIG_BIAS_PULL_DOWN; }
Since we have some bindings header for our hardcoded flags, let's use them when we can. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)