| Message ID | ar_CvNPWBA42BAlx@stanley.mountain |
|---|---|
| State | New |
| Headers | show |
| Series | [next] pinctrl: ambarella: fix NULL vs IS_ERR() bug in amb_pinctrl_register() | expand |
On Fri, Oct 2, 2026 at 4:42 PM Dan Carpenter <error27@gmail.com> wrote: > The devm_kasprintf_strarray() function never returns NULL, it returns > error pointers on error or a valid pointer on success. Fix the error > checking to match. > > Fixes: b40e9d140c24 ("pinctrl: ambarella: add CV75 pin controller") > Signed-off-by: Dan Carpenter <error27@gmail.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-ambarella.c b/drivers/pinctrl/pinctrl-ambarella.c index 83afef6a123f..5ed1010c5ce5 100644 --- a/drivers/pinctrl/pinctrl-ambarella.c +++ b/drivers/pinctrl/pinctrl-ambarella.c @@ -426,8 +426,8 @@ static int amb_pinctrl_register(struct amb_pinctrl *ipc) return -ENOMEM; names = devm_kasprintf_strarray(ipc->dev, "io", ipc->data->npins); - if (!names) - return -ENOMEM; + if (IS_ERR(names)) + return PTR_ERR(names); for (unsigned int pin = 0; pin < ipc->data->npins; pin++) { pindesc[pin].number = pin;
The devm_kasprintf_strarray() function never returns NULL, it returns error pointers on error or a valid pointer on success. Fix the error checking to match. Fixes: b40e9d140c24 ("pinctrl: ambarella: add CV75 pin controller") Signed-off-by: Dan Carpenter <error27@gmail.com> --- drivers/pinctrl/pinctrl-ambarella.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)