| Message ID | ad2fbe222ad715b3f7e6e093a7f822743e465f9a.1550201284.git.baolin.wang@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string | expand |
On Fri, Feb 15, 2019 at 12:55:19PM +0800, Baolin Wang wrote: > Change to use SoC compatible string instead of wildcard string. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > --- > Changes from v1: > - None. > --- > drivers/gpio/gpio-pmic-eic-sprd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c > index ac573da..24228cf 100644 > --- a/drivers/gpio/gpio-pmic-eic-sprd.c > +++ b/drivers/gpio/gpio-pmic-eic-sprd.c > @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev) > } > > static const struct of_device_id sprd_pmic_eic_of_match[] = { > - { .compatible = "sprd,sc27xx-eic", }, > + { .compatible = "sprd,sc2731-eic", }, You need to keep the old one if you care about backwards compatibility. If you don't then state why in the commit message. > { /* end of list */ } > }; > MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match); > -- > 1.7.9.5 >
On Tue, 19 Feb 2019 at 04:07, Rob Herring <robh@kernel.org> wrote: > > On Fri, Feb 15, 2019 at 12:55:19PM +0800, Baolin Wang wrote: > > Change to use SoC compatible string instead of wildcard string. > > > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > > --- > > Changes from v1: > > - None. > > --- > > drivers/gpio/gpio-pmic-eic-sprd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c > > index ac573da..24228cf 100644 > > --- a/drivers/gpio/gpio-pmic-eic-sprd.c > > +++ b/drivers/gpio/gpio-pmic-eic-sprd.c > > @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev) > > } > > > > static const struct of_device_id sprd_pmic_eic_of_match[] = { > > - { .compatible = "sprd,sc27xx-eic", }, > > + { .compatible = "sprd,sc2731-eic", }, > > You need to keep the old one if you care about backwards compatibility. > If you don't then state why in the commit message. > As we discussed before, our dts and drivers development are still in progress, and we always recompile and ship device trees at the same time as we compile and ship the kernel, so we do not need care about backwards compatibility. Yes, I will add the explanation in the commit message. Thanks.
diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c index ac573da..24228cf 100644 --- a/drivers/gpio/gpio-pmic-eic-sprd.c +++ b/drivers/gpio/gpio-pmic-eic-sprd.c @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev) } static const struct of_device_id sprd_pmic_eic_of_match[] = { - { .compatible = "sprd,sc27xx-eic", }, + { .compatible = "sprd,sc2731-eic", }, { /* end of list */ } }; MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
Change to use SoC compatible string instead of wildcard string. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> --- Changes from v1: - None. --- drivers/gpio/gpio-pmic-eic-sprd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)