From patchwork Wed Mar 16 00:48:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 598100 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qPtC80NzDz9sR9 for ; Wed, 16 Mar 2016 11:48:36 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=renesasgroup.onmicrosoft.com header.i=@renesasgroup.onmicrosoft.com header.b=PMMXGEO3; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965168AbcCPAsU (ORCPT ); Tue, 15 Mar 2016 20:48:20 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:28157 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933932AbcCPAsS (ORCPT ); Tue, 15 Mar 2016 20:48:18 -0400 Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie3.idc.renesas.com with ESMTP; 16 Mar 2016 09:48:16 +0900 Received: from relmlac3.idc.renesas.com (relmlac3.idc.renesas.com [10.200.69.23]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id 3C3CB401E2; Wed, 16 Mar 2016 09:48:16 +0900 (JST) Received: by relmlac3.idc.renesas.com (Postfix, from userid 0) id 1A04B1800A; Wed, 16 Mar 2016 09:48:16 +0900 (JST) Received: from relmlac3.idc.renesas.com (localhost [127.0.0.1]) by relmlac3.idc.renesas.com (Postfix) with ESMTP id 0C10B18070; Wed, 16 Mar 2016 09:48:16 +0900 (JST) Received: from relmlii1.idc.renesas.com [10.200.68.65] by relmlac3.idc.renesas.com with ESMTP id KAN19690; Wed, 16 Mar 2016 09:48:16 +0900 X-IronPort-AV: E=Sophos;i="5.22,559,1449500400"; d="scan'";a="206442311" Received: from mail-pu1apc01lp0020.outbound.protection.outlook.com (HELO APC01-PU1-obe.outbound.protection.outlook.com) ([65.55.88.20]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA; 16 Mar 2016 09:48:14 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zKay0XK/PKzsS3+kdupEYmEMNtT0YaNOVXgY01yHqhA=; b=PMMXGEO3ypplPfUgUEM17gOgZT7a8QcT9fJjqQhPWTfrOke2PrGkeZSNAJ8JHpPUxvNaKxkmUZ4d3g1tNpPZy3aGzOeWq41HkVVdaF1PQEiVHwBam4ahzSD+fjrYK8mAZ+36314jE4NFq7LpyyCT/pteWdHbeed2qdsYxUqMrA0= Authentication-Results: ideasonboard.com; dkim=none (message not signed) header.d=none;ideasonboard.com; dmarc=none action=none header.from=renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by SG2PR06MB1020.apcprd06.prod.outlook.com (10.161.9.28) with Microsoft SMTP Server (TLS) id 15.1.434.16; Wed, 16 Mar 2016 00:48:11 +0000 Message-ID: <8737rrfe1f.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH 2/2] pinctrl: sh-pfc: IPSRx and MOD_SELx should be set before GPSRx User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Laurent Pinchart , Geert Uytterhoeven , Linus Walleij CC: Magnus , Simon , , , In-Reply-To: <8760wnfe3r.wl%kuninori.morimoto.gx@renesas.com> References: <8760wnfe3r.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Wed, 16 Mar 2016 00:48:11 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: OS1PR01CA0049.jpnprd01.prod.outlook.com (25.164.162.31) To SG2PR06MB1020.apcprd06.prod.outlook.com (25.161.9.28) X-MS-Office365-Filtering-Correlation-Id: 7812047a-8671-43cc-5aaf-08d34d34a71f X-Microsoft-Exchange-Diagnostics: 1; SG2PR06MB1020; 2:bTXXMlK2WJoW0vlL/h5tvJ2Tjufpkyl2oEeH3hVoFbhbBzG+Snd+EajpqHrGmAh5NcznTcqFL/OWM38UEiY3v8neuxpSveALDl7380Zna7R5B7odM7uRFaYSTtDo3laRIp4S7tGA3/z1qNIlD6fMBhBy1UKpZIlHsxOmhy2T5JCK1cHVUm6HOqnmbHYsEHLp; 3:D/WU6gTqnHpPJNsqehEvdQlB0Udp4szleTfBwQaavnCABgOouY/KswS/DpDbr0AM5Vy6lq11PscPusmaqUbrbS578wjXvcPwKjg0SXvV4d+RaLR8ByyklagCefHSlUPk; 25:5qoBtrf9sfPUVCXaXWim4g6c6LSSybMQeYcOAJO8t1q8coD12CRYirIjKWXpn+hy74BsWBamyT73zsW7lC3zcIhlaygrMcE+qNx1MRN6faukV5naJEimOsrsiGkoHrZRUy2L9hqZLPRS1iDxJDKyerpYq2mI3jX9QNu643ZYCk7pQDvuFlwSKQIm+20nysPJ8yx0sggb2w9fkNzWhjuQheopljIVd23TGs3sx/dz0OzMsBfMMlyRnoY7T1rGQHF1Z01y33JGuLt5BnHT90qP/sJw+iYtJ1hmJqFB4zFGw6oyxW+v53U0dxSKIT0eOi3A X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1020; X-Microsoft-Exchange-Diagnostics: 1; SG2PR06MB1020; 20:WI9Adk+v+Lj+LdDep2X3GfHonr78DdlVB7JTodcxI+x2aEwZI1tfLUa4j0qKpoe3xOKSRF/rvdW3hTT7txrpjL9Wjetlnt3VuquvTm4gf3Fpj88tloRGXc7921a0/gVZy9e0mj8UceZ/+FXeip2z0FbQSPirwF4A70de9vNosfGOPOwks/55X4xpOldL71dT6IRzGRuCBtSpULQFjDEnFW4tD8hjgdBJQMZmD+cVRR2XHVkSsDgqaa9f68zIk46Nujf2qD7GAZJZlrb/QEQj/a8/o2z/X3cADBLxzMebRbL5yBXA55NN/sH/VYigY4z8FTddDip1TF1glVgpsrE7fe4nm9nu1Z3bQgpHO8H4GUcUY1sP7z1MUuDD+QHgrqmvZL5NhXvvWeseO3S3cop1WFbrwLOg0KQFPxLY6eLAMFbXq/DDqZAi54BT2hwQlVfUMNGIE1K5iSxpaU6Lkqw71L2rrs5bldaZDcwsswGSCdg9uNO/J4dmc8VVVXwaqNt9; 4:azTa72MVvzz6/Kpw+sXOQqHeVpKKzkR2hhrQz5oR5b75PT54WgX1IWOBV5dT4zcX0IIGYif11PW4XSmwvEKvDddx4E+jr2ReK9oYGeOGEnx+WBxBrQ6N4N8RVYr0uTdrpn4IardM7fz68sV8uqsybZNe6QTPXZaCAxhzyHNjzVBjwjLtnp31FOlS3uM4xCdLI2s+ztseE33mNlkvwXHiRS2+vI67YBSKMO7qoEXNr7+mTAFimmnG48FnXC/2Z6i5pE+zucDy5agRrsmwATBhepzOjQD+fIzdVZwA3XOYlDWAmVj3PM+YNwdLIF3k1vrvMNd6QXrBA8PO5w2X9nYIWi5eTjZlFZrE8ysFL68h2/PynWfoXQCGPupQIT3m2PIp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:SG2PR06MB1020; BCL:0; PCL:0; RULEID:; SRVR:SG2PR06MB1020; X-Forefront-PRVS: 08831F51DC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(47776003)(5004730100002)(189998001)(229853001)(5008740100001)(66066001)(36756003)(2950100001)(42186005)(5001770100001)(33646002)(53416004)(77096005)(6116002)(4326007)(2906002)(92566002)(76176999)(54356999)(1096002)(46406003)(3846002)(50466002)(23726003)(586003)(83506001)(81166005)(50986999)(19580405001)(86362001)(19580395003)(17423001)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:SG2PR06MB1020; H:morimoto-PC.renesas.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SG2PR06MB1020; 23:SKahHJYm7+UY8y9Ien2bf44w0LupvKJsAsLniDxrV?= =?us-ascii?Q?ZDIhGE52ugiAdc1yM3IogptaN/nND046LEGfyN68qU+wx76WZ1C6OKHd4ias?= =?us-ascii?Q?ZMo3cbv6+NJYnoR9kKqjXWD7vr08hQgl/B85ZTF71akztMUBFcwvOH3mjgDY?= =?us-ascii?Q?yLxUzibPchg7q/qm5ch4D1vF8563PZQxlO/pnCfpta2UiuqHr3NioW6EXjoq?= =?us-ascii?Q?qd+362SQR5gmjyflVKpLhiokDB4dIcw3ahhWFqBUevJaZlfE/CfCtK0Rz/im?= =?us-ascii?Q?HofplPiP+1bViTf5cIVf2hQJ2Yl6vP2lsAEWlso6MzK8XnoXhhAOdcf5yIZZ?= =?us-ascii?Q?LtlDgR0TzV4Rgkf1sIcefobjPgSjxav65Z7IRyVFg4RckcONJgXAhJA5k2DP?= =?us-ascii?Q?qyVEUyt52V0/3HOL/X3YmxlqGd0QgWlLzMaJLdAZc/ncVUI9bfgrOCqKxr5h?= =?us-ascii?Q?yyCtxF2P0N5DJIzO8Ygwd5Tack8NwUWEHktKr1t44bRM9WuQueZkJTp0K45j?= =?us-ascii?Q?viSWvOen4wp5fGpqCBN4JuH5/fUSYIE0H9pJoXBQHRkXp1uzRTLhXF9x3aou?= =?us-ascii?Q?ETVtbZXEv9LFP2w7N/CBHKZYWWQYr92j8ALt9NZu60lm//K+WfRIF2E2rAjf?= =?us-ascii?Q?DG9T56KPpaXvyBGShg5Ie2hyETppaNOb777J90GbafmY2xxvIvzoZu17hJsV?= =?us-ascii?Q?1ZltxvEkLKjoN88rA3JqAcliETwgrNUpWbj5gH7uSzLCCVipWMKkVBWHp0Uk?= =?us-ascii?Q?+cS6jy0XqVxLhUIoDxvnPbq2eYnAQWh2N/qNuD8XuL+6znPSB0a4jZb7gcwo?= =?us-ascii?Q?vNeq20cXmnh2SZm396NOlPMrwYYnfHc/sWV66tkxzCzPniKBiAPSLN3byOES?= =?us-ascii?Q?HxkH/lP8Qj7sZmkzcu6fBHIF4CCo2bPGgeDT9x5WWK42Tyg+kL/TDoMnWY6x?= =?us-ascii?Q?c3PzJ91wYtaaYIKKSEHYsTH22AFOTVrRkV0SV1Sow=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SG2PR06MB1020; 5:4YyrSFhW3aNs+NWEAlzpGToly91NUYcWI2ism71SePcwEwFrazq2thYuW9Ls9aH/5mUyx6HEGwPVji0Vdb3Y4p8avm2gNJTIIofEe57OqlMo9YSKNtvJWpKJyDaOLNpHte3FguXbRe9z3p7OsFNoxQ==; 24:XhS6apiGI6tFB77Fowd6pMnPS41dpf4nqaGO/cZHRbYOt6Cv4T3jIDm7yPtCcSstvC4JPiyx0ggNgyv8uAjki6O0egUNMGY1lK3rIHnustU=; 20:um1dJUzWfE9eEX4XOTLVgEMwIgq+K384G23/pRcd+DsZeQtGTDWte0tWncziWriaq09Dbty4BY2XGNPxRKJOm6Eem+5+gxBukz7W92gh+MEy6ZZzU01OpkPr4jU+793HYdPrrZf+gmc4719cwvBy2Na1xLBhNEfVF3X+mDXxO9E= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2016 00:48:11.7172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1020 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Kuninori Morimoto Gen2 / Gen3 datasheet will have below note in next version. This patch follows this note. IPSRx and MOD_SELx registers shall be set before setting GPSRx registers in case that they need to be configured. MOD_SELx registers can be set either earlier or later than setting IPSRx registers. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart --- drivers/pinctrl/sh-pfc/sh_pfc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h index 2b593fc..f174d61 100644 --- a/drivers/pinctrl/sh-pfc/sh_pfc.h +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h @@ -279,7 +279,7 @@ struct sh_pfc_soc_info { * - msel: Module selector */ #define PINMUX_IPSR_MSEL(ipsr, fn, msel) \ - PINMUX_DATA(fn##_MARK, FN_##msel, FN_##ipsr, FN_##fn) + PINMUX_DATA(fn##_MARK, FN_##msel, FN_##fn, FN_##ipsr) /* * Describe a pinmux configuration for a single-function pin with GPIO