From patchwork Thu Mar 15 15:53:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 886307 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OO6aWEHl"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 402CnS5xVWz9s2M for ; Fri, 16 Mar 2018 02:54:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932665AbeCOPxs (ORCPT ); Thu, 15 Mar 2018 11:53:48 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:43815 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932469AbeCOPxq (ORCPT ); Thu, 15 Mar 2018 11:53:46 -0400 Received: by mail-yw0-f193.google.com with SMTP id r66so4908531ywh.10; Thu, 15 Mar 2018 08:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lCzlokA2J6QYPyk/ts+7WjOUPA7gImYP6yEkE4BG4l4=; b=OO6aWEHloVb/FHw9iFwWQugCQ1Lw4Xn3ALreIABY44gBF0nEkFf8yT/cXZzoSGnEq5 b5J61v+4oo1FP5caP9mkPI0kHwJQ0DRTLxV+VTxzxGfu2CHv2pySXxG8aJc1y65QnsA+ gDqzyH+kDglBgpUZ0K7lGVKIQ2gpw4aKB6xX8quxbr/mCljbhqzRPEWgnTR3I0vR2NOy qsRbqcBw7S2yd3HLpvxXYKOMi/LoVPRkweuOeUoBbNDZh1s7jaq3gseUr6lEU0f9kxN9 D3gD/F/5NqWV2cGRL1exdFpUqlfEf4/717rWZ5hnry9eKudufobwrYz7bGqv9Z8Wmros yceQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lCzlokA2J6QYPyk/ts+7WjOUPA7gImYP6yEkE4BG4l4=; b=WBFashrh9ccR8UpRXh5KDv64KfLpf9PhsFE0FSF2r4edTw4HRjlIcobsBvI9Tv7am/ pf7+YJQ5Ijo4L9Unjk8iZB6HAivbOU0Gox1U7dIuIYPj8wLSwPwdZYv7ggoICtHOgbzG VrI6z/hCzjHdyHWY0t0cT70cOplNgY3hpyNZ5QWxDjA2ARWPn2u1XmVTAit4+3sbYzns IKxx6wOo2mdhcVXbU3Jcn8MrOseM7pV8FF+/YSnOIuBbv2H5Emr7xxDA0fk3G1K5i/Fj cZheYKNRnqX6uaq7JBuSK4Yp7Cgq2HvkjcaBjLJanucsxV7vKkTRDh2e0SBQpw4odAhb Gu0Q== X-Gm-Message-State: AElRT7EsBZIGTaRH2q9q2Hv5c2xe5YIvK0ka52iVcR06KKS7UPVPS2St dl+3gJZdT6juBj3cF4IWRnM= X-Google-Smtp-Source: AG47ELvR1WQhNKH/yCOBq/MtZcK20HAZ7a9qqLJrbBaZsQwBWq9Ymx9wlxEGA4EImqK36I2SB09CMA== X-Received: by 2002:a25:5d07:: with SMTP id r7-v6mr1847970ybb.482.1521129226081; Thu, 15 Mar 2018 08:53:46 -0700 (PDT) Received: from localhost ([72.188.97.40]) by smtp.gmail.com with ESMTPSA id u128sm1898300ywb.62.2018.03.15.08.53.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 08:53:45 -0700 (PDT) From: William Breathitt Gray To: linus.walleij@linaro.org Cc: andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, William Breathitt Gray Subject: [PATCH v2 8/8] gpio: ws16c48: Implement get_multiple callback Date: Thu, 15 Mar 2018 11:53:39 -0400 Message-Id: <78fd4e6464713068ba9292ba8ef5d9227cdd294c.1521128287.git.vilhelm.gray@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: References: Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The WinSystems WS16C48 device provides 48 lines of digital I/O accessed via six 8-bit ports. Since eight input lines are acquired on a single port input read, the WS16C48 GPIO driver may improve multiple input reads by utilizing a get_multiple callback. This patch implements the ws16c48_gpio_get_multiple function which serves as the respective get_multiple callback. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-ws16c48.c | 46 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/drivers/gpio/gpio-ws16c48.c b/drivers/gpio/gpio-ws16c48.c index 746648244bf3..9f2e7d0b48f9 100644 --- a/drivers/gpio/gpio-ws16c48.c +++ b/drivers/gpio/gpio-ws16c48.c @@ -129,6 +129,51 @@ static int ws16c48_gpio_get(struct gpio_chip *chip, unsigned offset) return !!(port_state & mask); } +static int ws16c48_gpio_get_multiple(struct gpio_chip *chip, + unsigned long *mask, unsigned long *bits) +{ + struct ws16c48_gpio *const ws16c48gpio = gpiochip_get_data(chip); + const unsigned int gpio_reg_size = 8; + size_t i; + const size_t num_ports = chip->ngpio / gpio_reg_size; + unsigned int bits_offset; + size_t word_index; + unsigned int word_offset; + unsigned long mask_word; + const unsigned long port_mask = GENMASK(gpio_reg_size, 0); + unsigned long port_state; + + /* clear bits array to a clean slate */ + bitmap_zero(bits, chip->ngpio); + + /* get bits are evaluated a gpio port register at a time */ + for (i = 0; i < num_ports; i++) { + /* gpio offset in bits array */ + bits_offset = i * gpio_reg_size; + + /* word index for bits array */ + word_index = BIT_WORD(bits_offset); + + /* gpio offset within current word of bits array */ + word_offset = bits_offset % BITS_PER_LONG; + + /* mask of get bits for current gpio within current word */ + word_mask = mask[word_index] & (port_mask << word_offset); + if (!word_mask) { + /* no get bits in this port so skip to next one */ + continue; + } + + /* read bits from current gpio port */ + port_state = inb(ws16c48gpio->base + i); + + /* store acquired bits at respective bits array offset */ + bits[word_index] |= port_state << word_offset; + } + + return 0; +} + static void ws16c48_gpio_set(struct gpio_chip *chip, unsigned offset, int value) { struct ws16c48_gpio *const ws16c48gpio = gpiochip_get_data(chip); @@ -383,6 +428,7 @@ static int ws16c48_probe(struct device *dev, unsigned int id) ws16c48gpio->chip.direction_input = ws16c48_gpio_direction_input; ws16c48gpio->chip.direction_output = ws16c48_gpio_direction_output; ws16c48gpio->chip.get = ws16c48_gpio_get; + ws16c48gpio->chip.get_multiple = ws16c48_gpio_get_multiple; ws16c48gpio->chip.set = ws16c48_gpio_set; ws16c48gpio->chip.set_multiple = ws16c48_gpio_set_multiple; ws16c48gpio->base = base[id];