| Message ID | 72c973da5670b5ae81d050c582948894ee4174f8.1634206453.git.michal.simek@xilinx.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: gpio: zynq: Add missing compatible strings | expand |
On Thu, 14 Oct 2021 12:14:18 +0200, Michal Simek wrote: > "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0" > compatible strings were not moved to yaml format. But they were in origin > text file. > > Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML") > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1540859 gpio@ff0a0000: '#address-cells', 'gpio-line-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml gpio@ff0a0000: '#address-cells', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml
Hi Rob, On 10/14/21 16:31, Rob Herring wrote: > On Thu, 14 Oct 2021 12:14:18 +0200, Michal Simek wrote: >> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0" >> compatible strings were not moved to yaml format. But they were in origin >> text file. >> >> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML") >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1540859 > > > gpio@ff0a0000: '#address-cells', 'gpio-line-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml > > gpio@ff0a0000: '#address-cells', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml > I sent patches for listing power-domain and gpio-line-names based on this patch. Thanks, Michal
On Thu, Oct 14, 2021 at 12:14 PM Michal Simek <michal.simek@xilinx.com> wrote: > "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0" > compatible strings were not moved to yaml format. But they were in origin > text file. > > Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML") > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Thu, 14 Oct 2021 12:14:18 +0200, Michal Simek wrote: > "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0" > compatible strings were not moved to yaml format. But they were in origin > text file. > > Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML") > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
čt 14. 10. 2021 v 12:14 odesílatel Michal Simek <michal.simek@xilinx.com> napsal: > > "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0" > compatible strings were not moved to yaml format. But they were in origin > text file. > > Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML") > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml > index 378da2649e66..980f92ad9eba 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml > @@ -11,7 +11,11 @@ maintainers: > > properties: > compatible: > - const: xlnx,zynq-gpio-1.0 > + enum: > + - xlnx,zynq-gpio-1.0 > + - xlnx,zynqmp-gpio-1.0 > + - xlnx,versal-gpio-1.0 > + - xlnx,pmc-gpio-1.0 > > reg: > maxItems: 1 > -- > 2.33.1 > Applied. M
diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml index 378da2649e66..980f92ad9eba 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml +++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml @@ -11,7 +11,11 @@ maintainers: properties: compatible: - const: xlnx,zynq-gpio-1.0 + enum: + - xlnx,zynq-gpio-1.0 + - xlnx,zynqmp-gpio-1.0 + - xlnx,versal-gpio-1.0 + - xlnx,pmc-gpio-1.0 reg: maxItems: 1
"xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0" compatible strings were not moved to yaml format. But they were in origin text file. Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML") Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)