From patchwork Fri Dec 4 10:44:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grygorii Strashko X-Patchwork-Id: 552653 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5E538140306 for ; Fri, 4 Dec 2015 21:44:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755361AbbLDKoS (ORCPT ); Fri, 4 Dec 2015 05:44:18 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:48731 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbbLDKoQ (ORCPT ); Fri, 4 Dec 2015 05:44:16 -0500 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id tB4Ai71H025740; Fri, 4 Dec 2015 04:44:07 -0600 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id tB4Ai7nh021894; Fri, 4 Dec 2015 04:44:07 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.224.2; Fri, 4 Dec 2015 04:44:06 -0600 Received: from [172.22.234.224] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id tB4Ai5J1013663; Fri, 4 Dec 2015 04:44:05 -0600 Subject: Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag To: Tony Lindgren References: <1448644860-29323-1-git-send-email-sudeep.holla@arm.com> <1448644860-29323-2-git-send-email-sudeep.holla@arm.com> <20151203181337.GV23396@atomide.com> <56608B72.1040101@ti.com> <20151203213715.GA23396@atomide.com> CC: Linus Walleij , Sudeep Holla , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , From: Grygorii Strashko Message-ID: <56616E74.9000604@ti.com> Date: Fri, 4 Dec 2015 12:44:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151203213715.GA23396@atomide.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 12/03/2015 11:37 PM, Tony Lindgren wrote: > * Grygorii Strashko [151203 10:36]: >> >> I think, this patch should not break our wake-up functionality. >> It will just change the moment when pcs_irq_handler() will be called: >> >> before this change: >> - suspend_enter() >> .... >> - arch_suspend_enable_irqs(); >> - ^ right here >> >> after this change: >> - suspend_enter() >> .... >> dpm_resume_noirq() >> - resume_device_irqs() >> ^ here >> >> Correct? And as for me this is more safe. > > I think there's more to it though. With both applied, it produces this on > coming back up from suspend: > > PM: noirq resume of devices complete after 18.127 msecs > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 123 at kernel/irq/manage.c:605 irq_set_irq_wake+0xbc/0xfc() > Unbalanced IRQ 375 wake disable > Modules linked in: ledtrig_default_on leds_gpio led_class rtc_twl twl4030_wdt > CPU: 0 PID: 123 Comm: bash Tainted: G W 4.4.0-rc3-dirty #2682 > Hardware name: Generic OMAP36xx (Flattened Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > ] (show_stack) from [] (dump_stack+0x84/0x9c) > [] (dump_stack) from [] (warn_slowpath_common+0x7c/0xb8) > [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40) > [] (warn_slowpath_fmt) from [] (irq_set_irq_wake+0xbc/0xfc) > [] (irq_set_irq_wake) from [] (device_wakeup_disarm_wake_irqs+0x70/0x12c) > [] (device_wakeup_disarm_wake_irqs) from [] (dpm_resume_noirq+0x20c/0x2e4) > [] (dpm_resume_noirq) from [] (suspend_devices_and_enter+0x1e4/0x6bc) > [] (suspend_devices_and_enter) from [] (pm_suspend+0x358/0x4b8) > [] (pm_suspend) from [] (state_store+0x64/0xb8) > [] (state_store) from [] (kobj_attr_store+0x14/0x20) > [] (kobj_attr_store) from [] (sysfs_kf_write+0x4c/0x50) > [] (sysfs_kf_write) from [] (kernfs_fop_write+0xbc/0x1cc) > [] (kernfs_fop_write) from [] (__vfs_write+0x24/0xd8) > [] (__vfs_write) from [] (vfs_write+0x94/0x154) > [] (vfs_write) from [] (SyS_write+0x40/0x94) > [] (SyS_write) from [] (ret_fast_syscall+0x0/0x1c) > ---[ end trace 321b51565e161bee ]--- > > And these both need to be applied together when we have a fix for the above > as otherwise we'll get the lock recursion Sudeep mentioned in patch 2/2. > Most probably below diff will fix above issue: ct->regs.mask = irq_setup->mask + i * 4; diff --git a/arch/arm/mach-omap2/prm_common.c b/arch/arm/mach-omap2/prm_common.c index 3fc2cbe..69cde67 100644 --- a/arch/arm/mach-omap2/prm_common.c +++ b/arch/arm/mach-omap2/prm_common.c @@ -338,6 +338,7 @@ int omap_prcm_register_chain_handler(struct omap_prcm_irq_setup *irq_setup) ct->chip.irq_ack = irq_gc_ack_set_bit; ct->chip.irq_mask = irq_gc_mask_clr_bit; ct->chip.irq_unmask = irq_gc_mask_set_bit; + ct->chip.flags = IRQCHIP_SKIP_SET_WAKE; ct->regs.ack = irq_setup->ack + i * 4;