| Message ID | 512f7f9909c9ff6964b34e0302eeb404e703f033.1484073325.git.vilhelm.gray@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 10/01/17 18:51, William Breathitt Gray wrote: > PC/104 drivers should be hidden on machines which do not support PC/104 > devices. This patch adds the PC104 Kconfig option as a dependency for > the relevant PC/104 device driver Kconfig options. > > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Hartmut Knaack <knaack.h@gmx.de> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Acked-by: Jonathan Cameron <jic23@kernel.org> Now the question is how to merge this one. Let me know if you want me to take this one via IIO after the first patch is in. If you want to take it another route I'm fine with that. Jonathan > --- > drivers/iio/adc/Kconfig | 2 +- > drivers/iio/counter/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 9c8b558ba19e..dc897b443a17 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -465,7 +465,7 @@ config STM32_ADC > > config STX104 > tristate "Apex Embedded Systems STX104 driver" > - depends on X86 && ISA_BUS_API > + depends on PC104 && X86 && ISA_BUS_API > select GPIOLIB > help > Say yes here to build support for the Apex Embedded Systems STX104 > diff --git a/drivers/iio/counter/Kconfig b/drivers/iio/counter/Kconfig > index 44627f6e4861..b37e5fc03149 100644 > --- a/drivers/iio/counter/Kconfig > +++ b/drivers/iio/counter/Kconfig > @@ -7,7 +7,7 @@ menu "Counters" > > config 104_QUAD_8 > tristate "ACCES 104-QUAD-8 driver" > - depends on X86 && ISA_BUS_API > + depends on PC104 && X86 && ISA_BUS_API > help > Say yes here to build support for the ACCES 104-QUAD-8 quadrature > encoder counter/interface device family (104-QUAD-8, 104-QUAD-4). > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 10, 2017 at 09:13:02PM +0000, Jonathan Cameron wrote: >On 10/01/17 18:51, William Breathitt Gray wrote: >> PC/104 drivers should be hidden on machines which do not support PC/104 >> devices. This patch adds the PC104 Kconfig option as a dependency for >> the relevant PC/104 device driver Kconfig options. >> >> Cc: Jonathan Cameron <jic23@kernel.org> >> Cc: Hartmut Knaack <knaack.h@gmx.de> >> Cc: Lars-Peter Clausen <lars@metafoo.de> >> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> >Acked-by: Jonathan Cameron <jic23@kernel.org> > >Now the question is how to merge this one. Let me know if you >want me to take this one via IIO after the first patch is in. >If you want to take it another route I'm fine with that. > >Jonathan This is such a simple patchset that I envision Greg K-H picking up all three patches via driver-core; however, I'm pretty indifferent about the ultimate path in the end. I'll leave it up to Greg K-H to decide. William Breathitt Gray -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 10, 2017 at 10:45 PM, William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > On Tue, Jan 10, 2017 at 09:13:02PM +0000, Jonathan Cameron wrote: >>On 10/01/17 18:51, William Breathitt Gray wrote: >>> PC/104 drivers should be hidden on machines which do not support PC/104 >>> devices. This patch adds the PC104 Kconfig option as a dependency for >>> the relevant PC/104 device driver Kconfig options. >>> >>> Cc: Jonathan Cameron <jic23@kernel.org> >>> Cc: Hartmut Knaack <knaack.h@gmx.de> >>> Cc: Lars-Peter Clausen <lars@metafoo.de> >>> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> >>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> >>Acked-by: Jonathan Cameron <jic23@kernel.org> >> >>Now the question is how to merge this one. Let me know if you >>want me to take this one via IIO after the first patch is in. >>If you want to take it another route I'm fine with that. >> >>Jonathan > > This is such a simple patchset that I envision Greg K-H picking up all > three patches via driver-core; however, I'm pretty indifferent about the > ultimate path in the end. I'll leave it up to Greg K-H to decide. As long as Greg merges the first patch we can merge the two others orthogonally I think. It's just Kconfig symbols, not things that break compile. (But I bet someone will come with automated warnings about unused symbols in the kernel...) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 11, 2017 at 04:45:26PM +0100, Linus Walleij wrote: > On Tue, Jan 10, 2017 at 10:45 PM, William Breathitt Gray > <vilhelm.gray@gmail.com> wrote: > > On Tue, Jan 10, 2017 at 09:13:02PM +0000, Jonathan Cameron wrote: > >>On 10/01/17 18:51, William Breathitt Gray wrote: > >>> PC/104 drivers should be hidden on machines which do not support PC/104 > >>> devices. This patch adds the PC104 Kconfig option as a dependency for > >>> the relevant PC/104 device driver Kconfig options. > >>> > >>> Cc: Jonathan Cameron <jic23@kernel.org> > >>> Cc: Hartmut Knaack <knaack.h@gmx.de> > >>> Cc: Lars-Peter Clausen <lars@metafoo.de> > >>> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > >>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > >>Acked-by: Jonathan Cameron <jic23@kernel.org> > >> > >>Now the question is how to merge this one. Let me know if you > >>want me to take this one via IIO after the first patch is in. > >>If you want to take it another route I'm fine with that. > >> > >>Jonathan > > > > This is such a simple patchset that I envision Greg K-H picking up all > > three patches via driver-core; however, I'm pretty indifferent about the > > ultimate path in the end. I'll leave it up to Greg K-H to decide. > > As long as Greg merges the first patch we can merge the two > others orthogonally I think. > > It's just Kconfig symbols, not things that break compile. > > (But I bet someone will come with automated warnings about > unused symbols in the kernel...) We already have that tool, scripts/checkkconfigsymbols.pl :) I'll go merge this first patch now. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 9c8b558ba19e..dc897b443a17 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -465,7 +465,7 @@ config STM32_ADC config STX104 tristate "Apex Embedded Systems STX104 driver" - depends on X86 && ISA_BUS_API + depends on PC104 && X86 && ISA_BUS_API select GPIOLIB help Say yes here to build support for the Apex Embedded Systems STX104 diff --git a/drivers/iio/counter/Kconfig b/drivers/iio/counter/Kconfig index 44627f6e4861..b37e5fc03149 100644 --- a/drivers/iio/counter/Kconfig +++ b/drivers/iio/counter/Kconfig @@ -7,7 +7,7 @@ menu "Counters" config 104_QUAD_8 tristate "ACCES 104-QUAD-8 driver" - depends on X86 && ISA_BUS_API + depends on PC104 && X86 && ISA_BUS_API help Say yes here to build support for the ACCES 104-QUAD-8 quadrature encoder counter/interface device family (104-QUAD-8, 104-QUAD-4).
PC/104 drivers should be hidden on machines which do not support PC/104 devices. This patch adds the PC104 Kconfig option as a dependency for the relevant PC/104 device driver Kconfig options. Cc: Jonathan Cameron <jic23@kernel.org> Cc: Hartmut Knaack <knaack.h@gmx.de> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/iio/adc/Kconfig | 2 +- drivers/iio/counter/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)