From patchwork Thu Mar 19 20:17:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baruch Siach X-Patchwork-Id: 452225 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A671314008F for ; Fri, 20 Mar 2015 07:18:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750889AbbCSUR7 (ORCPT ); Thu, 19 Mar 2015 16:17:59 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:56569 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbbCSUR7 (ORCPT ); Thu, 19 Mar 2015 16:17:59 -0400 Received: from tarshish.tkos.co.il (unknown [10.0.8.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPSA id 47CD1440784; Thu, 19 Mar 2015 22:17:39 +0200 (IST) From: Baruch Siach To: Linus Walleij Cc: linux-gpio@vger.kernel.org, Baruch Siach Subject: [PATCH 2/2] pinctrl: pinconf-generic: add dt node names to error messages Date: Thu, 19 Mar 2015 22:17:42 +0200 Message-Id: <4e6157290f7236e0bd5c3cc29a677aed5255f497.1426796262.git.baruch@tkos.co.il> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This makes the error message much more useful. Signed-off-by: Baruch Siach --- drivers/pinctrl/pinconf-generic.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c index b5fbfb3584d9..e63ad9fbd388 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -307,14 +307,16 @@ int pinconf_generic_dt_subnode_to_map(struct pinctrl_dev *pctldev, if (ret < 0) { /* EINVAL=missing, which is fine since it's optional */ if (ret != -EINVAL) - dev_err(dev, "could not parse property function\n"); + dev_err(dev, "%s: could not parse property function\n", + of_node_full_name(np)); function = NULL; } ret = pinconf_generic_parse_dt_config(np, pctldev, &configs, &num_configs); if (ret < 0) { - dev_err(dev, "could not parse node property\n"); + dev_err(dev, "%s: could not parse node property\n", + of_node_full_name(np)); return ret; }