| Message ID | 20260520110504.13969-1-sozdayvek@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: pca953x: propagate regulator_enable() error from resume | expand |
On Wed, 20 May 2026 16:05:04 +0500, Stepan Ionichev wrote: > pca953x_resume() returns 0 when regulator_enable() fails, dropping > the real error code and masking the failure as a successful resume. > The caller then proceeds as if the chip is powered, while the > regulator is in fact disabled. > > Return ret so PM core sees the actual failure. > > [...] Applied, thanks! [1/1] gpio: pca953x: propagate regulator_enable() error from resume https://git.kernel.org/brgl/c/be460cedb67ab803c1bebceac19b1d44acb85d30 Best regards,
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 52e96cc5f..b9c905a0f 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -1411,7 +1411,7 @@ static int pca953x_resume(struct device *dev) ret = regulator_enable(chip->regulator); if (ret) { dev_err(dev, "Failed to enable regulator: %d\n", ret); - return 0; + return ret; } }
pca953x_resume() returns 0 when regulator_enable() fails, dropping the real error code and masking the failure as a successful resume. The caller then proceeds as if the chip is powered, while the regulator is in fact disabled. Return ret so PM core sees the actual failure. Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com> --- drivers/gpio/gpio-pca953x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)