diff mbox series

gpio: max730x: use devres to shrink and simplify code

Message ID 20241017121447.73754-1-brgl@bgdev.pl
State New
Headers show
Series gpio: max730x: use devres to shrink and simplify code | expand

Commit Message

Bartosz Golaszewski Oct. 17, 2024, 12:14 p.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Use managed variants of gpiochip_add_data() and mutex_init() to drop a
label and lose a couple LOC.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpio-max730x.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

Comments

Linus Walleij Oct. 17, 2024, 1:11 p.m. UTC | #1 
On Thu, Oct 17, 2024 at 2:14 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Use managed variants of gpiochip_add_data() and mutex_init() to drop a
> label and lose a couple LOC.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Bartosz Golaszewski Oct. 21, 2024, 7:24 a.m. UTC | #2 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Thu, 17 Oct 2024 14:14:47 +0200, Bartosz Golaszewski wrote:
> Use managed variants of gpiochip_add_data() and mutex_init() to drop a
> label and lose a couple LOC.
> 
> 

Applied, thanks!

[1/1] gpio: max730x: use devres to shrink and simplify code
      commit: 57e0e7188712dae39045e4004c7c7f9ce0a36193

Best regards,
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-max730x.c b/drivers/gpio/gpio-max730x.c
index 701795b9d329..e688c13c8cc3 100644
--- a/drivers/gpio/gpio-max730x.c
+++ b/drivers/gpio/gpio-max730x.c
@@ -165,7 +165,10 @@  int __max730x_probe(struct max7301 *ts)
 
 	pdata = dev_get_platdata(dev);
 
-	mutex_init(&ts->lock);
+	ret = devm_mutex_init(ts->dev, &ts->lock);
+	if (ret)
+		return ret;
+
 	dev_set_drvdata(dev, ts);
 
 	/* Power up the chip and disable IRQ output */
@@ -206,17 +209,11 @@  int __max730x_probe(struct max7301 *ts)
 			int offset = (i - 1) * 4 + j;
 			ret = max7301_direction_input(&ts->chip, offset);
 			if (ret)
-				goto exit_destroy;
+				return ret;
 		}
 	}
 
-	ret = gpiochip_add_data(&ts->chip, ts);
-	if (!ret)
-		return ret;
-
-exit_destroy:
-	mutex_destroy(&ts->lock);
-	return ret;
+	return devm_gpiochip_add_data(ts->dev, &ts->chip, ts);
 }
 EXPORT_SYMBOL_GPL(__max730x_probe);
 
@@ -226,8 +223,6 @@  void __max730x_remove(struct device *dev)
 
 	/* Power down the chip and disable IRQ output */
 	ts->write(dev, 0x04, 0x00);
-	gpiochip_remove(&ts->chip);
-	mutex_destroy(&ts->lock);
 }
 EXPORT_SYMBOL_GPL(__max730x_remove);