| Message ID | 20240501-pinctrl-cleanup-v1-20-797ceca46e5c@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: Use scope based of_node_put() cleanups | expand |
On Wed, 2024-05-01 at 20:56 +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Use scope based of_node_put() cleanup to simplify code. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > index 5bb8fd0d1e41..61fbfddb5938 100644 > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > @@ -2629,14 +2629,13 @@ static struct regmap *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx, > return ctx->maps[ip]; > > if (ip == ASPEED_IP_GFX) { > - struct device_node *node; > + struct device_node *node __free(device_node) = NULL; > struct regmap *map; > > node = of_parse_phandle(ctx->dev->of_node, > "aspeed,external-nodes", 0); > if (node) { > map = syscon_node_to_regmap(node); > - of_node_put(node); > if (IS_ERR(map)) > return map; > } else > @@ -2648,7 +2647,7 @@ static struct regmap *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx, > } > > if (ip == ASPEED_IP_LPC) { > - struct device_node *np; > + struct device_node *np __free(device_node) = NULL; > struct regmap *map; > > np = of_parse_phandle(ctx->dev->of_node, > @@ -2660,7 +2659,6 @@ static struct regmap *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx, > return ERR_PTR(-ENODEV); > > map = syscon_node_to_regmap(np->parent); > - of_node_put(np); > if (IS_ERR(map)) > return map; I think I agree with Krzysztof's feedback on the Samsung patch[1], and that I prefer the existing approach for the Aspeed driver. My reasoning suggests the existing implementation does the right thing. That said, the code could be adjusted to use early returns and consistent variable names, which might make it easier to reason about. I'll consider a follow-up patch to address that. Regardless, thanks for taking the time to explore the cleanup. Andrew [1]: https://lore.kernel.org/lkml/34193501-5b7b-4ffd-8549-a04c6930d02d@kernel.org/ > } else >
> Subject: Re: [PATCH 20/21] pinctrl: aspeed: g5: Use scope based > of_node_put() cleanups > > On Wed, 2024-05-01 at 20:56 +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Use scope based of_node_put() cleanup to simplify code. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > > b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > > index 5bb8fd0d1e41..61fbfddb5938 100644 > > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > > @@ -2629,14 +2629,13 @@ static struct regmap > *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx, > > return ctx->maps[ip]; > > > > if (ip == ASPEED_IP_GFX) { > > - struct device_node *node; > > + struct device_node *node __free(device_node) = NULL; > > struct regmap *map; > > > > node = of_parse_phandle(ctx->dev->of_node, > > "aspeed,external-nodes", 0); > > if (node) { > > map = syscon_node_to_regmap(node); > > - of_node_put(node); > > if (IS_ERR(map)) > > return map; > > } else > > @@ -2648,7 +2647,7 @@ static struct regmap > *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx, > > } > > > > if (ip == ASPEED_IP_LPC) { > > - struct device_node *np; > > + struct device_node *np __free(device_node) = NULL; > > struct regmap *map; > > > > np = of_parse_phandle(ctx->dev->of_node, > > @@ -2660,7 +2659,6 @@ static struct regmap > *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx, > > return ERR_PTR(-ENODEV); > > > > map = syscon_node_to_regmap(np->parent); > > - of_node_put(np); > > if (IS_ERR(map)) > > return map; > > I think I agree with Krzysztof's feedback on the Samsung patch[1], and that I > prefer the existing approach for the Aspeed driver. My reasoning suggests the > existing implementation does the right thing. That said, the code could be > adjusted to use early returns and consistent variable names, which might > make it easier to reason about. No problem, let's keep the code as it is. Thanks, Peng I'll consider a follow-up patch to address that. > > Regardless, thanks for taking the time to explore the cleanup. > > Andrew > > [1]: > https://lore.ke/ > rnel.org%2Flkml%2F34193501-5b7b-4ffd-8549- > a04c6930d02d%40kernel.org%2F&data=05%7C02%7Cpeng.fan%40nxp.com > %7C44ef77e479264eccd73f08dc6a4263c6%7C686ea1d3bc2b4c6fa92cd99c5 > c301635%7C0%7C0%7C638502080600849943%7CUnknown%7CTWFpbGZs > b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn > 0%3D%7C0%7C%7C%7C&sdata=tuUu1IeqM5sQjqiN1fwzPAbSoZw%2FUNEd2 > u%2BzpaBhJ4M%3D&reserved=0 > > > } else > >
diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c index 5bb8fd0d1e41..61fbfddb5938 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c @@ -2629,14 +2629,13 @@ static struct regmap *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx, return ctx->maps[ip]; if (ip == ASPEED_IP_GFX) { - struct device_node *node; + struct device_node *node __free(device_node) = NULL; struct regmap *map; node = of_parse_phandle(ctx->dev->of_node, "aspeed,external-nodes", 0); if (node) { map = syscon_node_to_regmap(node); - of_node_put(node); if (IS_ERR(map)) return map; } else @@ -2648,7 +2647,7 @@ static struct regmap *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx, } if (ip == ASPEED_IP_LPC) { - struct device_node *np; + struct device_node *np __free(device_node) = NULL; struct regmap *map; np = of_parse_phandle(ctx->dev->of_node, @@ -2660,7 +2659,6 @@ static struct regmap *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx, return ERR_PTR(-ENODEV); map = syscon_node_to_regmap(np->parent); - of_node_put(np); if (IS_ERR(map)) return map; } else