From patchwork Sat Mar 23 13:28:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Bee X-Patchwork-Id: 1915164 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=CHOsttFC; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org; envelope-from=linux-gpio+bounces-4570-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V20RN2wVVz1yXy for ; Sun, 24 Mar 2024 00:29:36 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D0CCEB22138 for ; Sat, 23 Mar 2024 13:29:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 37A2645033; Sat, 23 Mar 2024 13:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CHOsttFC" X-Original-To: linux-gpio@vger.kernel.org Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6B72942A; Sat, 23 Mar 2024 13:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711200540; cv=none; b=JUv+uMzYr3JomVYn3BVEtvBpZnuzKs4FRahsTy0Sp/lj/iK7AaF+LA/uFcNQBkBtcfjHhDBSi8lkv2I8xVCIsTGPFHRNBkpnlGum4GhXdkoujNXafKmCmIs8kiizkSRYtBIXpRg+G/ou9TpyRAigPf2qAFyAHC7BtbOPM0EO1XQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711200540; c=relaxed/simple; bh=yFDUI6x6hmSF8fS6smv8BmO9sfjw/v+7224JoNNkZZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PPU2J/ms8rIVWniGoYnqS6qpW900HC2/m0l18vrJUTtBvQSJusxMf8s27dQXGmbblgkLCDmQEP5sVx5H6TRxGII9ZdrgMAQvZRvSW84vM69rPnC1m/oCkyDXbyIzAs4z6PwSeocGz4OTNDHh+8aJpprd7iODjAYco1B0Ri2Ezlw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CHOsttFC; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-33fd8a2a3e6so1835614f8f.0; Sat, 23 Mar 2024 06:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711200537; x=1711805337; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8zwG1vyYusOfDUs/yU9E4qQ9XIYsM0NPCoK6QrfbLsc=; b=CHOsttFCcjbcUHgOSDCV1KVcdnO2n2KomKbTy8CUY/7/unyQfydR4Ww51/76QktnVp yOwFZxIW6vPqujcmaR83VNg+4qB3AUF/NAO0xQVpzVmNADK9aFYZZIzPW6G1LfSHhMGs kR0nco3clweE0cS8/5ziBDGcGVE7EzajTGYmEP11a6zH+rODx2dpKAwPCoaiZboW6nY4 dBMJbVBW0vWr6H9NMh/Y1UmWzhnh5MFNmFPJlN3ZjKW3k89CB/SvlRTNzPKz6K6LcEcA TKf57egk5nS6VGrcafalRZA6dyzb93uvO9/GWR0SWbG+wLhtO3pxDBf75T4pJNSqinUH eIyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711200537; x=1711805337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8zwG1vyYusOfDUs/yU9E4qQ9XIYsM0NPCoK6QrfbLsc=; b=S9VDSrwj3YEd1qJbd9Urgf/30jS24LNfw9OrTHDsPfZTnkhyOSgrPsO5n0y1gtb4hn nn5ILxyxwgovrQTJHqFUfSohD0BkueaguoMzYlXt6x0nGySV+rAe8NzMl7XCSQ0SYuf/ uLpXuvuZCAldNG51KhqmezsOQOPDHl3g86tGWM7tYr4JG7qbvvy5Z1MqvfWaWPMwyzml W6AH5QQVUK30r7+n785r5gvfcMuJhh9gWUfbvrY5Tyg1Oj7/K9zzE98rV+I1kUr3ducp S7EFUzPa1xl/XuqR/QUp+E3HPjCBXISOeYoRd+Pqy1BepbBaJ4kAHGVNpSaOw0Aecyk4 J+fQ== X-Forwarded-Encrypted: i=1; AJvYcCU+pOYs4HlBJPrgQYNXGYAa8fiEObDNbVKhjr4ZQMAgURExW1yF4+FJBoj5+JMI4BWubh+wgAcFHrCIBlXZB6qDbKVyJLLhS7QILr3gJEV4M7bH2Mh1aBDVF/ZJhtZr+tehhJsvk5SnRuw1NYhmm6XXJZ+2RBR6+cpOLXeXf0tTHkLVZ/I= X-Gm-Message-State: AOJu0YxL3uCfDyZBh5M48DT32drQHIhxP178oTiZRyyoLToz8znCNK3R XP6I4slNsYx5ry3qfvRIP5YjTILHH9AMii6xB25S9yBGkIBZEWc= X-Google-Smtp-Source: AGHT+IENR8QMP5qQWKeIGQ/4dPn3qxLpYPx925ZdrXpFlIgCRoyh0lnIm76I/c23VHjVPV1Fe41R9g== X-Received: by 2002:a5d:5486:0:b0:33e:d461:6c1c with SMTP id h6-20020a5d5486000000b0033ed4616c1cmr1316456wrv.21.1711200536763; Sat, 23 Mar 2024 06:28:56 -0700 (PDT) Received: from U4.lan ([2a02:810b:f40:4600:fbb8:7547:139d:a40f]) by smtp.gmail.com with ESMTPSA id x17-20020adfffd1000000b00341babb8af0sm3076061wrs.7.2024.03.23.06.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Mar 2024 06:28:56 -0700 (PDT) From: Alex Bee To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Linus Walleij , Liam Girdwood , Mark Brown Cc: Chris Zhong , Zhang Qing , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Alex Bee Subject: [PATCH v3 4/5] regulator: rk808: Support apply_bit for rk808_set_suspend_voltage_range Date: Sat, 23 Mar 2024 14:28:01 +0100 Message-ID: <20240323132757.141861-10-knaerzche@gmail.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240323132757.141861-2-knaerzche@gmail.com> References: <20240323132757.141861-2-knaerzche@gmail.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 rk808_set_suspend_voltage_range currently does not account the existence of apply_bit/apply_reg. This adds support for those in same way it is done in regulator_set_voltage_sel_regmap and is required for the upcoming RK816 support Signed-off-by: Alex Bee --- changes since v1: - none drivers/regulator/rk808-regulator.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c index d89ae7f16d7a..a6a563e402d0 100644 --- a/drivers/regulator/rk808-regulator.c +++ b/drivers/regulator/rk808-regulator.c @@ -534,15 +534,25 @@ static int rk808_set_suspend_voltage_range(struct regulator_dev *rdev, int uv) { unsigned int reg; int sel = regulator_map_voltage_linear_range(rdev, uv, uv); + int ret; if (sel < 0) return -EINVAL; reg = rdev->desc->vsel_reg + RK808_SLP_REG_OFFSET; - return regmap_update_bits(rdev->regmap, reg, - rdev->desc->vsel_mask, - sel); + ret = regmap_update_bits(rdev->regmap, reg, + rdev->desc->vsel_mask, + sel); + if (ret) + return ret; + + if (rdev->desc->apply_bit) + ret = regmap_update_bits(rdev->regmap, rdev->desc->apply_reg, + rdev->desc->apply_bit, + rdev->desc->apply_bit); + + return ret; } static int rk805_set_suspend_enable(struct regulator_dev *rdev)