diff mbox series

gpiolib: use dev_err when gpiod_configure_flags failed

Message ID 20240315011015.3106272-1-peng.fan@oss.nxp.com
State New
Headers show
Series gpiolib: use dev_err when gpiod_configure_flags failed | expand

Commit Message

Peng Fan (OSS) March 15, 2024, 1:10 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Using dev_err to show error message will make life easier.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko March 15, 2024, 11:12 a.m. UTC | #1 
On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Using dev_err to show error message will make life easier.

dev_err()

an error

...

It's unclear what the use case is and how this does make life easier.
We need to know more!
Peng Fan March 18, 2024, 2:03 a.m. UTC | #2 
> Subject: Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed
> 
> On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Using dev_err to show error message will make life easier.
> 
> dev_err()
> 
> an error
> 
> ...
> 
> It's unclear what the use case is and how this does make life easier.
> We need to know more!

I forgot to add gpio-ranges in gpio node, then it always fail in my driver
probe to configure pinctrl. So if using dev_err(), it will be easier for
me to locate the error point.

Thanks,
Peng.

> 
> --
> With Best Regards,
> Andy Shevchenko
Andy Shevchenko March 18, 2024, 10:25 a.m. UTC | #3 
On Mon, Mar 18, 2024 at 02:03:12AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed
> > On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > wrote:

...

> > It's unclear what the use case is and how this does make life easier.
> > We need to know more!
> 
> I forgot to add gpio-ranges in gpio node, then it always fail in my driver
> probe to configure pinctrl. So if using dev_err(), it will be easier for
> me to locate the error point.

At least make sure something like the above is in the commit message of the
next version.
diff mbox series

Patch

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index ce94e37bcbee..37fe9db0bd74 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4233,7 +4233,7 @@  struct gpio_desc *gpiod_find_and_request(struct device *consumer,
 
 	ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
 	if (ret < 0) {
-		dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
+		dev_err(consumer, "setup of GPIO %s failed: %d\n", con_id, ret);
 		gpiod_put(desc);
 		return ERR_PTR(ret);
 	}